Improve incremental document update #4277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olafurpg
approved these changes
May 23, 2024
abeatrix
reviewed
May 23, 2024
| reason: undefined, | ||
| }) | ||
|
|
||
| if (contentChanges) { |
There was a problem hiding this comment.
This will always be true even if contentChanges is empty right? Cause Boolean([]) returns true ?
Will need to update to:
Suggested change
| if (contentChanges) { | |
| if (contentChanges?.length) { |
There was a problem hiding this comment.
ha, I was just opening this PR to make the same comment, will fix in a followup PR
olafurpg
added a commit
that referenced
this pull request
May 23, 2024
The PR #4277 was a lesson that we have very brittle code around dealing with document synchronization. This PR is an attempt to improve code health by - Adding tests! - Being more rigorous with null handling - Making the code a bit easier to follow (hopefully)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test plan
In a client: