Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chat: Refactor update notices to be IDE-specific #4637

Merged
merged 5 commits into from
Jun 24, 2024
Merged

Conversation

abeatrix
Copy link
Contributor

@abeatrix abeatrix commented Jun 21, 2024

Part of https://linear.app/sourcegraph/issue/CODY-2291/port-chat-ux-vscode-isms-to-jetbrains

Make IDE-specific release notes URLs and version info to update notices

  • Update the codebase to send the existing config values from config.agentExtensionVersion and config.agentIDE when config.isRunningInsideAgent is true.
  • When the IDE and version number is provided, we will generate the release note URL based on the IDE in releaseNotesURL function
  • Update Storybook to show VersionUpdatedNotice components for Jetbrains Stable and Nightly release.

NOTE: This assumes each agent IDE are sending the correct IDE name and version number to the webview for the update notice to be displayed. When those are not provided, the updated notice will not be rendered.

BREAKING CHANGE: The VersionUpdatedNotice component now requires IDE and version props.

Test plan

  • Added tests should all be passing
  • Green CI to confirm this change doesn't break the existing E2E test for VS Code update notice and should work as intended when the agent IDE provides the correct IDE name and version number.

You can start the story book with pnpm run storybook to verify the components are working as expected:

image

Make IDE-specific release notes URLs and version info to update notices

BREAKING CHANGE: The `VersionUpdatedNotice` component now requires `IDE` and `version` props.
@abeatrix abeatrix marked this pull request as draft June 21, 2024 03:19
@abeatrix abeatrix marked this pull request as ready for review June 21, 2024 17:02
@abeatrix abeatrix requested review from dominiccooney and a team June 21, 2024 17:02
Copy link
Contributor

@mkondratek mkondratek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@abeatrix abeatrix merged commit 0291202 into main Jun 24, 2024
40 checks passed
@abeatrix abeatrix deleted the bee/ide-notices branch June 24, 2024 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants