feat: code smell command, display commands error in chat

agent/src/editor.ts

@@ -79,6 +79,10 @@ export class AgentEditor implements Editor {
         return this.getActiveTextEditorSelection()
     }
 
+    public getActiveTextEditorSelectionOrVisibleContent(): ActiveTextEditorSelection | null {
+        throw new Error('Method not implemented.')
+    }
+
     public getActiveTextEditorDiagnosticsForRange(): ActiveTextEditorDiagnostic[] | null {
         throw new Error('Method not implemented.')
     }

lib/shared/src/chat/prompts/default-prompts.json

@@ -10,10 +10,9 @@
     },
     "Explain Code": {
       "slashCommand": "explain",
-      "prompt": "Explain what the selected code does in simple terms. Assume the audience is a beginner programmer who has just learned the language features and basic syntax. Focus on explaining: 1) The purpose of the code 2) What input(s) it takes 3) What output(s) it produces 4) How it achieves its purpose through the logic and algorithm. 5) Any important logic flows or data transformations happening. Use simple language a beginner could understand. Include enough detail to give a full picture of what the code aims to accomplish without getting too technical. Format the explanation in coherent paragraphs, using proper punctuation and grammar. Write the explanation assuming no prior context about the code is known. Do not make assumptions about variables or functions not shown in the shared code.",
+      "prompt": "Explain what the selected code does in simple terms. Assume the audience is a beginner programmer who has just learned the language features and basic syntax. Focus on explaining: 1) The purpose of the code 2) What input(s) it takes 3) What output(s) it produces 4) How it achieves its purpose through the logic and algorithm. 5) Any important logic flows or data transformations happening. Use simple language a beginner could understand. Include enough detail to give a full picture of what the code aims to accomplish without getting too technical. Format the explanation in coherent paragraphs, using proper punctuation and grammar. Write the explanation assuming no prior context about the code is known. Do not make assumptions about variables or functions not shown in the shared code. Start the answer with the name of the code that is being explained.",
       "context": {
-        "currentFile": true,
-        "selection": true
+        "currentFile": true
       }
     },
     "Generate Unit Tests": {
@@ -24,6 +23,10 @@
         "currentFile": true,
         "selection": true
       }
+    },
+    "Code Smell": {
+      "slashCommand": "smell",
+      "prompt": "Please review and analyze the {languageName} code I have selected and identify potential areas for improvement related to code smells, readability, maintainability, performance, security, etc. Do not list issues already addressed in the given code. Focus on providing up to 5 constructive suggestions that could make the code more robust, efficient, or align with best practices. For each suggestion, provide a brief explanation of the potential benefits. After listing any recommendations, summarize if you found notable opportunities to enhance the code quality overall or if the code generally follows sound design principles. If no issues found, reply 'There are no errors.'"
     }
   }
 }

lib/shared/src/chat/prompts/index.ts

@@ -66,6 +66,7 @@ export interface CodyPromptContext {
     filePath?: string
     directoryPath?: string
     none?: boolean
+    strict?: boolean // add additional prompt at the end to prevent hallucination
 }
 
 export type CodyPromptType = 'workspace' | 'user' | 'default' | 'recently used'
@@ -74,8 +75,7 @@ export const ConfigFileName = {
     vscode: '.vscode/cody.json',
 }
 
-// Default to include selection context only
+// Default to not include codebase context
 export const defaultCodyPromptContext: CodyPromptContext = {
     codebase: false,
-    selection: true,
 }

lib/shared/src/chat/prompts/templates.ts

@@ -1,10 +1,3 @@
-const selection_prompt = `
-I have questions about this selected {languageName} code from {fileName}:
-\`\`\`
-{selectedText}
-\`\`\`
-`
-
 const instruction_prompt = `Please follow these rules when answering my question:
 - Your answers and suggestions should based on the shared context only.
 - Do not suggest anything that would break the working code.
@@ -22,10 +15,12 @@ export const answers = {
 }
 
 export const prompts = {
-    selection: selection_prompt,
     instruction: instruction_prompt,
 }
 
 export const rules = {
     hallucination: prevent_hallucinations,
 }
+
+export const displayFileName = `\n
+    File: `

lib/shared/src/chat/prompts/utils.ts

@@ -0,0 +1,91 @@
+import path from 'path'
+
+import { ContextMessage } from '../../codebase-context/messages'
+import { ActiveTextEditorSelection } from '../../editor'
+import { CHARS_PER_TOKEN, MAX_AVAILABLE_PROMPT_LENGTH, MAX_RECIPE_INPUT_TOKENS } from '../../prompt/constants'
+import { truncateText } from '../../prompt/truncation'
+import { getFileExtension, getNormalizedLanguageName } from '../recipes/helpers'
+import { Interaction } from '../transcript/interaction'
+
+import { CodyPromptContext } from '.'
+
+/**
+ * Gets the name of the parent directory from a directory path.
+ */
+export const getParentDirName = (dirPath: string): string => path.basename(path.dirname(dirPath))
+
+/**
+ * Gets the current directory path from the file path param
+ */
+export const getCurrentDirPath = (filePath: string): string => path.dirname(filePath)
+
+/**
+ * Returns a Promise resolving to an Interaction object representing an error response from the assistant.
+ *
+ * @param errorMsg - The error message text to include in the assistant response.
+ * @param displayText - Optional human-readable display text for the request.
+ * @returns A Promise resolving to the Interaction object.
+ */
+export async function interactionWithAssistantError(errorMsg: string, displayText = ''): Promise<Interaction> {
+    return Promise.resolve(
+        new Interaction(
+            { speaker: 'human', displayText },
+            { speaker: 'assistant', displayText: errorMsg, error: errorMsg },
+            Promise.resolve([]),
+            []
+        )
+    )
+}
+
+/**
+ * Generates a prompt text string with the provided prompt and code selection.
+ *
+ * @param prompt - The prompt text to include after the code snippet.
+ * @param selection - The ActiveTextEditorSelection containing the code snippet.
+ * @returns The constructed prompt text string, or null if no selection provided.
+ */
+export function promptTextWithCodeSelection(
+    prompt: string,
+    selection?: ActiveTextEditorSelection | null
+): string | null {
+    if (!selection) {
+        return null
+    }
+    const extension = getFileExtension(selection.fileName)
+    const languageName = getNormalizedLanguageName(extension)
+    const codePrefix = `I have this ${languageName} code selected in my editor from ${selection.fileName}:`
+
+    // Use the whole context window for the prompt because we're attaching no files
+    const maxTokenCount = MAX_AVAILABLE_PROMPT_LENGTH - (codePrefix.length + prompt.length) / CHARS_PER_TOKEN
+    const truncatedCode = truncateText(selection.selectedText, Math.min(maxTokenCount, MAX_RECIPE_INPUT_TOKENS))
+    const promptText = `${codePrefix}\n\n<selected>\n${truncatedCode}\n</selected>\n\n${prompt.replace(
+        '{languageName}',
+        languageName
+    )}`
+    return promptText
+}
+
+export async function makeInteraction(
+    text: string,
+    displayText?: string,
+    contextMessages?: Promise<ContextMessage[]>,
+    assistantText?: string,
+    assistantDisplayText?: string
+): Promise<Interaction> {
+    return Promise.resolve(
+        new Interaction(
+            { speaker: 'human', text, displayText },
+            { speaker: 'assistant', text: assistantText, displayText: assistantDisplayText },
+            Promise.resolve(contextMessages || []),
+            []
+        )
+    )
+}
+
+export function isOnlySelectionRequired(contextConfig: CodyPromptContext, selectedText: string): boolean {
+    return (
+        contextConfig.selection !== false &&
+        selectedText.trim().length > 0 &&
+        Object.entries(contextConfig).length === 1
+    )
+}