Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prometheus: scrape pg, redis instances by default #580

Merged
merged 1 commit into from Sep 10, 2021

Conversation

bobheadxi
Copy link
Member

Convenience and parity with k8s (would have been useful for https://github.com/sourcegraph/customer/issues/470 where I realized too late they were on Compose)

Without this the postgres dashboards are also super unhelpful on Compose, e.g. https://demo.sourcegraph.com/-/debug/grafana/d/postgres/postgres?orgId=1

Checklist

@bobheadxi bobheadxi requested review from benjaminwgordon and a team September 9, 2021 16:15
Copy link
Member

@daxmc99 daxmc99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I honestly didn't know that we didn't monitor these services in docker-compose 🤯
This probably warrants a changelog entry though

bobheadxi added a commit to sourcegraph/sourcegraph that referenced this pull request Sep 10, 2021
@bobheadxi bobheadxi merged commit 005f6f7 into master Sep 10, 2021
@bobheadxi bobheadxi deleted the prom/more-targets branch September 10, 2021 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants