repo-updater: Add readinessProbe #816
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bobheadxi
approved these changes
Aug 10, 2020
|
@bobheadxi Yep, I will not merge that until the image is released, I created the PR so I could link it to the other one and show what I'm changing. |
pecigonzalo
changed the title
|
Rerunning tests, as the old tests ran with the old image. I have also verified this locally and probes work correctly. Hopefully this will reduce the deployment downtime for this service. |
|
Due to our tests using the currently released image, we will wait for 3.19 to be released which includes the change that fixes this PR. |
55 tasks
pecigonzalo
force-pushed
the
feature/repo-updater-healthcheck
branch
from
0252dd9
to
b785fff
Compare
bobheadxi
added a commit
that referenced
this pull request
Aug 21, 2020
commit 0415290 Author: Gonzalo Peci <pecigonzalo@users.noreply.github.com> Date: Fri Aug 21 13:56:08 2020 +0200 repo-updater: Add readinessProbe (#816) * repo-updater: Add readinessProbe * fixup! repo-updater: Add readinessProbe commit 2b33c8c Author: uwedeportivo <534011+uwedeportivo@users.noreply.github.com> Date: Thu Aug 20 20:49:41 2020 -0700 up grafana to 3.19.1 (#833) commit cc3fdc1 Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Thu Aug 20 20:32:53 2020 -0700 Update index.docker.io/sourcegraph/prometheus Docker tag to v3.19.1 (#830) Co-authored-by: Renovate Bot <bot@renovateapp.com> commit 4a55ae6 Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Thu Aug 20 20:28:47 2020 -0700 Update Sourcegraph Docker images Docker tags to v3.19.1 (#832) Co-authored-by: Renovate Bot <bot@renovateapp.com> commit 04cab68 Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Fri Aug 21 01:51:50 2020 +0000 Update Sourcegraph Docker images Docker tags to v3.19.1-rc.2 (#829) Co-authored-by: Renovate Bot <bot@renovateapp.com>
trentgrover-wf
pushed a commit
to trentgrover-wf/deploy-sourcegraph
that referenced
this pull request
Sep 16, 2020
* repo-updater: Add readinessProbe * fixup! repo-updater: Add readinessProbe
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently dont have any checks to ensure
repo-updateris ready before tearing down its old deployment, but we useRollingUpdatefor its upgrades. This sometimes causes downtime as the new pod is started but unable to serve traffic yet.It should also help fix/reduce the alerts regarding
repo-updaterdowntime as a result.Notes
Requires: sourcegraph/sourcegraph#12880