This repository has been archived by the owner on Oct 12, 2022. It is now read-only.
fs: Support incremental file updates #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI is acting very funny with this. Both runs should be testing identical commits, but they are not. The PR CI build is testing an older commit I pushed, and it won't update to the new one. CI is passing on this if travis tested the proper commit. It also passes locally. |
|
@keegancsmith Indeed, Travis CI does seem to be testing the wrong commit. Strange. LGTM. |
sqs
approved these changes
Feb 9, 2017
We still don't advertise we support this since I have not tested this thoroughly. However, I am working on a PR now which refactors this logic to make it more testable.
keegancsmith
force-pushed
the
k/did-change
branch
from
d770362
to
a84ef62
Compare
|
I am rebasing on latest master and repushing just to try and trick travis into giving me the green I deserve :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We still don't advertise we support this since I have not tested this
thoroughly. However, I am working on a PR now which refactors this logic to make
it more testable.