Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mobile scrolling bug #3666

Closed
elzannewentzel opened this issue May 31, 2022 · 2 comments · Fixed by #6080
Closed

Mobile scrolling bug #3666

elzannewentzel opened this issue May 31, 2022 · 2 comments · Fixed by #6080
Labels
bug Something isn't working 🏗 Handbook website Any issues and asks related to the handbook website, not the content of the handbook. team/content-platform

Comments

@elzannewentzel
Copy link
Contributor

elzannewentzel commented May 31, 2022 •
edited

@lmelende20 reported an issue with the scrolling of handbook pages on mobile.
Example:
https://user-images.githubusercontent.com/88658267/171152709-3ef7cdf9-80eb-43de-a9e4-6e51599d0a82.MP4

The video is on the homepage on mobile and the issue is also on the internship page.

Slack thread
@elzannewentzel elzannewentzel added 🏗 Handbook website Any issues and asks related to the handbook website, not the content of the handbook. team/content-platform bug Something isn't working labels May 31, 2022
@elzannewentzel elzannewentzel added this to the HB - Sprint 6 milestone Jun 3, 2022
@elzannewentzel elzannewentzel modified the milestones: HB - Sprint 6, HB Sprint 7 Jun 20, 2022
@bretthayes bretthayes removed this from the HB Sprint 7 milestone Jul 18, 2022
nielthiart added a commit to nielthiart/handbook that referenced this issue Jan 24, 2023
@nielthiart
Hide sub-navigation on mobile to stop screen flickering while scrolling
2dd23bd 
Ref: sourcegraph#3666

The sidebar appears above the content on screen sizes below 900px wide.

As we scroll down the page, sub-menus in the sidebar become active.

This pushes content down which deactivates the sub-menu, causing a loop.
@nielthiart nielthiart mentioned this issue Jan 24, 2023
Merged
@nielthiart
Copy link
Contributor

nielthiart commented Jan 24, 2023 •
edited

This is caused by the navigation height changing, which pushes content down on viewports below 900px. This causes a loop where a sub-menu repeatedly alternates between active/inactive.

Affects all pages with sidebar nav, and any viewport below 900px wide.

sourcegraph-handbook-flicker.mp4

nielthiart added a commit to nielthiart/handbook that referenced this issue Jan 24, 2023
@nielthiart
Hide sub-navigation on mobile to stop screen flickering while scrolling
523bf1a 
Ref: sourcegraph#3666

The sidebar appears above the content on screen sizes below 900px wide.

As we scroll down the page, sub-menus in the sidebar become active.

This pushes content down which deactivates the sub-menu, causing a loop.
@sqs
Copy link
Member

sqs commented Jan 24, 2023

@nielthiart Thank you for the PR!

@sqs sqs closed this as completed in #6080 Jan 24, 2023
sqs added a commit that referenced this issue Jan 24, 2023
@nielthiart @sqs
Hide sub-navigation on mobile to stop screen flickering while scrolli…
ec9b076 
…ng (#6080)

* Hide sub-navigation on mobile to stop screen flickering while scrolling

Ref: #3666

The sidebar appears above the content on screen sizes below 900px wide.

As we scroll down the page, sub-menus in the sidebar become active.

This pushes content down which deactivates the sub-menu, causing a loop.

* fix whitespace

Co-authored-by: Quinn Slack <quinn@slack.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working 🏗 Handbook website Any issues and asks related to the handbook website, not the content of the handbook. team/content-platform
Projects
Content Platform Work
Status: Done ✅
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Hide sub-navigation on mobile to stop screen flickering while scrolling nielthiart/handbook
4 participants
@sqs @nielthiart @bretthayes @elzannewentzel