Hide sub-navigation on mobile to stop screen flickering while scrolling #6080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for sourcegraph-handbook ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
Ref: sourcegraph#3666 The sidebar appears above the content on screen sizes below 900px wide. As we scroll down the page, sub-menus in the sidebar become active. This pushes content down which deactivates the sub-menu, causing a loop.
nielthiart
force-pushed
the
fix-scroll-flicker
branch
from
2dd23bd
to
523bf1a
Compare
|
I confirmed this fixes the issue for me locally. |
|
Thank you so much, @nielthiart! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3666
The sidebar appears above the content on screen sizes below 900px wide.
As we scroll down the page, sub-menus in the sidebar become active.
This pushes content down which deactivates the sub-menu, causing a loop.
An alternative solution would be to always display sub-navigation on screens below 900px, but this pushes content way down pages with many nav items, which is probably not ideal.