Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sentrycore: add first-class metadata from resource #57

Merged
merged 1 commit into from
May 17, 2023

Conversation

bobheadxi
Copy link
Member

Sentry has some fancy features around version tracking, environments, and whatnot - this change propagates relevant fields from the resource we initialize everything with onto events so that we might be able to take advantage of it.

@bobheadxi bobheadxi force-pushed the sentry-add-first-class-metadata branch from c40f788 to 94abe0c Compare May 17, 2023 22:55
@codecov-commenter
Copy link

Codecov Report

Merging #57 (94abe0c) into main (49ac5ad) will increase coverage by 0.60%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##             main      #57      +/-   ##
==========================================
+ Coverage   60.50%   61.11%   +0.60%     
==========================================
  Files          16       16              
  Lines         628      630       +2     
==========================================
+ Hits          380      385       +5     
+ Misses        224      222       -2     
+ Partials       24       23       -1     
Impacted Files Coverage Δ
sinks.go 0.00% <ø> (ø)
internal/sinkcores/sentrycore/worker.go 77.14% <66.66%> (+2.63%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@bobheadxi bobheadxi merged commit ac58b7c into main May 17, 2023
@bobheadxi bobheadxi deleted the sentry-add-first-class-metadata branch May 17, 2023 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants