Skip to content

Commit

Permalink
Remove unused subscriptions RBAC role (#51717)
Browse files Browse the repository at this point in the history
Not used at the moment, was a leftover in a PR that I forgot to remove.
  • Loading branch information
eseliger committed May 10, 2023
1 parent 7ba9b85 commit 7cf2a50
Show file tree
Hide file tree
Showing 5 changed files with 1 addition and 19 deletions.
4 changes: 0 additions & 4 deletions client/web/src/rbac/constants.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,3 @@
export const BatchChangesReadPermission = 'BATCH_CHANGES#READ'

export const BatchChangesWritePermission = 'BATCH_CHANGES#WRITE'

export const SubscriptionsReadPermission = 'SUBSCRIPTIONS#READ'

export const SubscriptionsWritePermission = 'SUBSCRIPTIONS#WRITE'
4 changes: 0 additions & 4 deletions cmd/frontend/graphqlbackend/schema.graphql
Original file line number Diff line number Diff line change
Expand Up @@ -9700,10 +9700,6 @@ enum PermissionNamespace {
This represents the Batch Changes namespace.
"""
BATCH_CHANGES
"""
This represents the subscriptions namespace.
"""
SUBSCRIPTIONS
}

"""
Expand Down
4 changes: 0 additions & 4 deletions internal/rbac/constants.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 0 additions & 4 deletions internal/rbac/schema.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,3 @@ namespaces:
actions:
- READ
- WRITE
- name: SUBSCRIPTIONS
actions:
- READ
- WRITE
4 changes: 1 addition & 3 deletions internal/types/types.go
Original file line number Diff line number Diff line change
Expand Up @@ -874,8 +874,7 @@ func (n PermissionNamespace) String() string {
// Valid checks if a namespace is valid and supported by the Sourcegraph RBAC system.
func (n PermissionNamespace) Valid() bool {
switch n {
case BatchChangesNamespace,
SubscriptionsNamespace:
case BatchChangesNamespace:
return true
default:
return false
Expand All @@ -884,7 +883,6 @@ func (n PermissionNamespace) Valid() bool {

// BatchChangesNamespace represents the Batch Changes namespace.
const BatchChangesNamespace PermissionNamespace = "BATCH_CHANGES"
const SubscriptionsNamespace PermissionNamespace = "SUBSCRIPTIONS"

type Permission struct {
ID int32
Expand Down

0 comments on commit 7cf2a50

Please sign in to comment.