ci: run client linters on changed files (#33701)

sourcegraph · Apr 14, 2022 · 868472f · 868472f
1 parent c31661b
commit 868472f
Show file tree

Hide file tree

Showing 35 changed files with 119 additions and 75 deletions.
diff --git a/.vscode/tasks.json b/.vscode/tasks.json
@@ -39,7 +39,7 @@
     {
       "label": "stylelint",
       "command": "yarn",
-      "args": ["-s", "run", "all:stylelint", "--", "--formatter", "compact"],
+      "args": ["-s", "run", "lint:css:all", "--", "--formatter", "compact"],
       "problemMatcher": {
         "owner": "stylelint",
         "applyTo": "closedDocuments",

diff --git a/client/branded/package.json b/client/branded/package.json
@@ -5,8 +5,8 @@
   "license": "Apache-2.0",
   "scripts": {
     "storybook": "STORIES_GLOB=client/branded/src/**/*.story.tsx yarn workspace @sourcegraph/storybook run start",
-    "eslint": "eslint --cache '**/*.[jt]s?(x)'",
-    "stylelint": "stylelint 'src/**/*.scss' --quiet",
+    "lint:js": "eslint --cache '**/*.[jt]s?(x)'",
+    "lint:css": "stylelint 'src/**/*.scss' --quiet",
     "test": "jest"
   }
 }
diff --git a/client/browser/package.json b/client/browser/package.json
@@ -23,8 +23,8 @@
     "release:firefox": "./scripts/release-firefox.sh",
     "release:npm": "TS_NODE_COMPILER_OPTIONS=\"{\\\"module\\\":\\\"commonjs\\\"}\" ts-node ./scripts/publish-npm.ts",
     "lint": "yarn run eslint && yarn run stylelint",
-    "eslint": "eslint --cache '**/*.[jt]s?(x)'",
-    "stylelint": "stylelint 'src/**/*.scss'",
+    "lint:js": "eslint --cache '**/*.[jt]s?(x)'",
+    "lint:css": "stylelint 'src/**/*.scss'",
     "clean": "rm -rf build/ dist/ *.zip *.xpi .checksum",
     "test": "jest --testPathIgnorePatterns end-to-end integration",
     "test-e2e": "mocha './src/end-to-end/**/*.test.ts'",

diff --git a/client/build-config/package.json b/client/build-config/package.json
@@ -7,7 +7,7 @@
   "sideEffects": false,
   "license": "Apache-2.0",
   "scripts": {
-    "eslint": "eslint --cache 'src/**/*.[jt]s?(x)'",
+    "lint:js": "eslint --cache 'src/**/*.[jt]s?(x)'",
     "test": "jest"
   }
 }
diff --git a/client/client-api/package.json b/client/client-api/package.json
@@ -7,7 +7,7 @@
   "sideEffects": false,
   "license": "Apache-2.0",
   "scripts": {
-    "eslint": "eslint --cache 'src/**/*.[jt]s?(x)'",
+    "lint:js": "eslint --cache 'src/**/*.[jt]s?(x)'",
     "test": "jest"
   }
 }
diff --git a/client/codeintellify/package.json b/client/codeintellify/package.json
@@ -7,7 +7,7 @@
   "sideEffects": false,
   "license": "Apache-2.0",
   "scripts": {
-    "eslint": "eslint --cache 'src/**/*.[jt]s?(x)'",
+    "lint:js": "eslint --cache 'src/**/*.[jt]s?(x)'",
     "test": "jest"
   }
-}
+}
diff --git a/client/codeintellify/src/testutils/github/styles.css b/client/codeintellify/src/testutils/github/styles.css
@@ -1,3 +1,4 @@
+/* stylelint-disable */
 .github-testase * {
     box-sizing: border-box;
 }

diff --git a/client/codeintellify/src/testutils/sourcegraph/styles.css b/client/codeintellify/src/testutils/sourcegraph/styles.css
@@ -1,3 +1,4 @@
+/* stylelint-disable */
 .sourcegraph-testcase * {
     box-sizing: border-box;
 }

diff --git a/client/common/package.json b/client/common/package.json
@@ -7,7 +7,7 @@
   "sideEffects": false,
   "license": "Apache-2.0",
   "scripts": {
-    "eslint": "eslint --cache 'src/**/*.[jt]s?(x)'",
+    "lint:js": "eslint --cache 'src/**/*.[jt]s?(x)'",
     "test": "jest"
   }
 }
diff --git a/client/eslint-plugin-sourcegraph/package.json b/client/eslint-plugin-sourcegraph/package.json
@@ -10,7 +10,7 @@
   ],
   "main": "lib/index.js",
   "scripts": {
-    "eslint": "echo 'TODO: add proper ESLint config, issue #19448'",
+    "lint:js": "echo 'TODO: add proper ESLint config, issue #19448'",
     "test": "mocha tests --recursive"
   },
   "dependencies": {

diff --git a/client/extension-api-types/package.json b/client/extension-api-types/package.json
@@ -19,7 +19,7 @@
   ],
   "sideEffects": false,
   "scripts": {
-    "eslint": "eslint 'src/**/*.[jt]s?(x)'",
+    "lint:js": "eslint 'src/**/*.[jt]s?(x)'",
     "prepublishOnly": "yarn run eslint"
   },
   "peerDependencies": {

diff --git a/client/extension-api/package.json b/client/extension-api/package.json
@@ -21,7 +21,7 @@
   ],
   "sideEffects": false,
   "scripts": {
-    "eslint": "eslint 'src/*.[jt]s?(x)'",
+    "lint:js": "eslint 'src/*.[jt]s?(x)'",
     "docs": "typedoc",
     "prepublishOnly": "yarn run eslint && yarn run docs"
   },

diff --git a/client/http-client/package.json b/client/http-client/package.json
@@ -7,7 +7,7 @@
   "sideEffects": false,
   "license": "Apache-2.0",
   "scripts": {
-    "eslint": "eslint --cache 'src/**/*.[jt]s?(x)'",
+    "lint:js": "eslint --cache 'src/**/*.[jt]s?(x)'",
     "test": "jest"
   }
 }
diff --git a/client/search-ui/package.json b/client/search-ui/package.json
@@ -8,7 +8,7 @@
   "license": "Apache-2.0",
   "scripts": {
     "storybook": "STORIES_GLOB=client/search-ui/src/**/*.story.tsx yarn workspace @sourcegraph/storybook run start",
-    "eslint": "eslint --cache 'src/**/*.[jt]s?(x)'",
+    "lint:js": "eslint --cache 'src/**/*.[jt]s?(x)'",
     "test": "jest"
   }
 }
diff --git a/client/search-ui/src/input/CodeMirrorQueryInput.module.scss b/client/search-ui/src/input/CodeMirrorQueryInput.module.scss
@@ -1,3 +1,5 @@
+// This rule is disable to preserve 1-1 mapping between `DecoratedToken` types and classes.
+/* stylelint-disable selector-class-pattern */
 .root {
     flex: 1;
     min-width: 0;
@@ -46,6 +48,7 @@
             code {
                 background-color: rgba(220, 220, 220, 0.4);
                 border-radius: var(--border-radius);
+                /* stylelint-disable-next-line declaration-property-unit-allowed-list */
                 padding: 0 0.4em;
             }
 

diff --git a/client/search-ui/src/input/CodeMirrorQueryInput.tsx b/client/search-ui/src/input/CodeMirrorQueryInput.tsx
@@ -375,7 +375,7 @@ const tokenDecorators: { [key: string]: Decoration } = Object.fromEntries(
 const emptyDecorator = Decoration.mark({})
 const focusedFilterDeco = Decoration.mark({ class: styles.focusedFilter })
 
-// Chooses the correct decorator for the decorated token. Copied (and adapated)
+// Chooses the correct decorator for the decorated token. Copied (and adapted)
 // from decoratedToMonaco (decoratedToken.ts).
 const decoratedToDecoration = (token: DecoratedToken): Decoration => {
     let cssClass = 'identifier'

diff --git a/client/search-ui/src/results/progress/StreamingProgressSkippedPopover.module.scss b/client/search-ui/src/results/progress/StreamingProgressSkippedPopover.module.scss
@@ -30,6 +30,7 @@
 
     // Border should appear directly under the width of the icon
     // Halfway past the icon, minus half the border size
+    /* stylelint-disable scss/operator-no-newline-after */
     margin-left: calc(
         var(--icon-inline-size) / 2 - var(--streaming-skipped-item-message-border-size) / 2 +
             var(--streaming-skipped-item-button-margin)
@@ -39,6 +40,7 @@
         var(--icon-inline-size) / 2 - var(--streaming-skipped-item-message-border-size) / 2 +
             var(--streaming-skipped-item-button-margin)
     );
+    /* stylelint-enable scss/operator-no-newline-after */
 
     margin-right: var(--streaming-skipped-item-button-margin);
 }

diff --git a/client/search/package.json b/client/search/package.json
@@ -7,7 +7,7 @@
   "sideEffects": false,
   "license": "Apache-2.0",
   "scripts": {
-    "eslint": "eslint --cache 'src/**/*.[jt]s?(x)'",
+    "lint:js": "eslint --cache 'src/**/*.[jt]s?(x)'",
     "test": "jest"
   }
 }
diff --git a/client/shared/package.json b/client/shared/package.json
@@ -5,8 +5,8 @@
   "license": "Apache-2.0",
   "scripts": {
     "storybook": "STORIES_GLOB=client/shared/src/**/*.story.tsx yarn workspace @sourcegraph/storybook run start",
-    "eslint": "eslint --cache '**/*.[jt]s?(x)'",
-    "stylelint": "stylelint 'src/**/*.scss' --quiet",
+    "lint:js": "eslint --cache '**/*.[jt]s?(x)'",
+    "lint:css": "stylelint 'src/**/*.scss' --quiet",
     "test": "jest",
     "graphql": "gulp graphQlSchema",
     "schema": "gulp schema",

diff --git a/client/storybook/package.json b/client/storybook/package.json
@@ -7,7 +7,7 @@
   "license": "Apache-2.0",
   "main": "./src/index.ts",
   "scripts": {
-    "eslint": "eslint --cache 'src/**/*.[jt]s?(x)'",
+    "lint:js": "eslint --cache 'src/**/*.[jt]s?(x)'",
     "start": "TS_NODE_TRANSPILE_ONLY=true start-storybook -p 9001 -c ./src -s ./assets,../../ui/assets",
     "build": "TS_NODE_TRANSPILE_ONLY=true build-storybook -c ./src -s ./assets,../../ui/assets",
     "build:webpack-stats": "TS_NODE_TRANSPILE_ONLY=true WEBPACK_DLL_PLUGIN=false start-storybook -c ./src -s ./assets --smoke-test --webpack-stats-json ./storybook-static --loglevel warn",

diff --git a/client/template-parser/package.json b/client/template-parser/package.json
@@ -7,7 +7,7 @@
   "sideEffects": false,
   "license": "Apache-2.0",
   "scripts": {
-    "eslint": "eslint --cache 'src/**/*.[jt]s?(x)'",
+    "lint:js": "eslint --cache 'src/**/*.[jt]s?(x)'",
     "test": "jest"
   }
 }
diff --git a/client/vscode/.stylelintrc.json b/client/vscode/.stylelintrc.json
@@ -0,0 +1,11 @@
+{
+  "extends": ["../../.stylelintrc.json"],
+  "overrides": [
+    {
+      "files": ["./src/webview/index.scss"],
+      "rules": {
+        "filenames/match-regex": null
+      }
+    }
+  ]
+}
diff --git a/client/vscode/package.json b/client/vscode/package.json
@@ -207,7 +207,7 @@
     }
   },
   "scripts": {
-    "eslint": "eslint --cache '**/*.[jt]s?(x)'",
+    "lint:js": "eslint --cache '**/*.[jt]s?(x)'",
     "test": "ts-node ./tests/runTests.ts",
     "package": "ts-node ./scripts/package.ts",
     "task:gulp": "cross-env NODE_OPTIONS=\"--max_old_space_size=8192\" gulp",

diff --git a/client/web/package.json b/client/web/package.json
@@ -27,8 +27,8 @@
     "watch-webpack": "yarn task:gulp watchWebpack",
     "webpack": "yarn task:gulp webpack",
     "lint": "yarn run eslint && gulp unusedExports && yarn run stylelint",
-    "eslint": "NODE_OPTIONS=\"--max_old_space_size=16192\" eslint --cache '**/*.[tj]s?(x)'",
-    "stylelint": "stylelint 'src/**/*.scss' --quiet",
+    "lint:js": "NODE_OPTIONS=\"--max_old_space_size=16192\" eslint --cache '**/*.[tj]s?(x)'",
+    "lint:css": "stylelint 'src/**/*.scss' --quiet",
     "browserslist": "browserslist",
     "analyze-bundle": "WEBPACK_USE_NAMED_CHUNKS=true NODE_ENV=production ENTERPRISE=1 WEBPACK_ANALYZER=1 yarn build",
     "bundlesize": "bundlesize --config=./bundlesize.config.js"

diff --git a/client/wildcard/package.json b/client/wildcard/package.json
@@ -8,8 +8,8 @@
   "license": "Apache-2.0",
   "scripts": {
     "storybook": "STORIES_GLOB=client/wildcard/src/**/*.story.tsx yarn workspace @sourcegraph/storybook run start",
-    "eslint": "eslint --cache '**/*.[jt]s?(x)'",
-    "stylelint": "stylelint 'src/**/*.scss' --quiet",
+    "lint:js": "eslint --cache '**/*.[jt]s?(x)'",
+    "lint:css": "stylelint 'src/**/*.scss' --quiet",
     "test": "jest"
   }
 }
diff --git a/dev/ci/yarn-web-integration.sh b/dev/ci/yarn-web-integration.sh
@@ -11,7 +11,7 @@ echo "--- Yarn install in root"
 yarn --mutex network --frozen-lockfile --network-timeout 60000
 
 echo "--- Run integration test suite"
-yarn percy exec yarn cover-integration:base "$@"
+yarn percy exec yarn _cover-integration "$@"
 
 echo "--- Process NYC report"
 yarn nyc report -r json

diff --git a/dev/foreach-ts-project.sh b/dev/foreach-ts-project.sh
@@ -29,7 +29,6 @@ DIRS=(
   client/storybook
   client/client-api
   dev/release
-  dev/ts-morph
 )
 
 run_command() {

diff --git a/dev/release/package.json b/dev/release/package.json
@@ -3,8 +3,8 @@
   "description": "Scripts for managing release captain duties",
   "private": true,
   "scripts": {
-    "release": "../../node_modules/.bin/ts-node --transpile-only ./src/main.ts",
-    "eslint": "../../node_modules/.bin/eslint 'src/**/*.ts'"
+    "release": "ts-node --transpile-only ./src/main.ts",
+    "lint:js": "eslint --cache 'src/**/*.[jt]s?(x)'"
   },
   "dependencies": {}
 }
diff --git a/doc/dev/background-information/architecture/architecture.css b/doc/dev/background-information/architecture/architecture.css
@@ -1,3 +1,4 @@
+/* stylelint-disable */
 @import url('https://fonts.googleapis.com/css2?family=Source+Code+Pro:wght@400;600&display=swap');
 
 @media (prefers-color-scheme: dark) {