Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

monitoring: no easy way to trigger alerts for testing #12423

Closed
bobheadxi opened this issue Jul 23, 2020 · 4 comments · Fixed by #12532
Closed

monitoring: no easy way to trigger alerts for testing #12423

bobheadxi opened this issue Jul 23, 2020 · 4 comments · Fixed by #12532
Assignees
Milestone

Comments

@bobheadxi
Copy link
Member

This is a pain point I've felt during dev, but I was able to work around this by changing thresholds manually

A bit trickier for customers - to test the alertmanager side of things (notifier config), they can do something like https://gist.github.com/cherti/61ec48deaaab7d288c9fcf17e700853a at the moment, with url='http://localhost:30090/alertmanager/api/v1/alerts' and kubectl port-forward svc/prometheus 30090, but this is not ideal, and the labels won't match what we actually have

We might want a way to say "create a test critical alert" easily. This could be a dummy 0/1 metric that has a toggle via API or UI or similar

@slimsag
Copy link
Member

slimsag commented Jul 23, 2020

Yes, I think this is very much needed 👍

Whatever we do should work for testing both warning and critical alerts independently, I think

V1 of this could look like a GraphQL API request you make from https://sourcegraph.com/api/console that is linked in our docs. V2 could be an actual button in the UI near site config.

@bobheadxi bobheadxi added this to the 3.19 milestone Jul 28, 2020
@bobheadxi
Copy link
Member Author

Adding as a prerequisite to per-team alerting

@bobheadxi
Copy link
Member Author

Added to per-team alerts project - would like to get this in before merging https://github.com/sourcegraph/deploy-sourcegraph-dot-com/pull/3073, since it'll make it easy to test

@bobheadxi
Copy link
Member Author

Hm not actually important for per-team alerts, since the current implementation at #12532 doesn't support setting owners (and I think it might be a good idea to not add this - though open to thoughts)

Happy to merge https://github.com/sourcegraph/deploy-sourcegraph-dot-com/pull/3073 without it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants