Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add back blame-on-current-line behavior to git-extras #1552

Closed
sqs opened this issue Dec 22, 2018 · 6 comments
Closed

add back blame-on-current-line behavior to git-extras #1552

sqs opened this issue Dec 22, 2018 · 6 comments
Assignees
@vanesa
Labels
extensions Sourcegraph extensions feature-request
Milestone
3.1

Comments

@sqs
Copy link
Member

sqs commented Dec 22, 2018 •
edited

Sourcegraph used to show blame info for the selected line. Now it only lets you toggle blame on/off for the entire file, and it shows the blame info for the first line of each hunk. Many people liked the previous behavior, and we want to bring it back.

Blocked on #2026 to add the extension APIs necessary for this.
@sqs sqs added this to the 3.0 milestone Dec 22, 2018
@sqs sqs self-assigned this Dec 22, 2018
@felixfbecker
Copy link
Contributor

Yes please 🙇

@sqs sqs added feature-request release-blocker Prevents us from releasing: https://about.sourcegraph.com/handbook/engineering/releases labels Dec 31, 2018
@sqs
Copy link
Member Author

sqs commented Jan 4, 2019

Waiting for @lguychard to add the following to the extension API, then I will implement this in the git-extras extension:

  • ability to listen for changes to active text editor
  • ability to listen for changes to TextEditor#selections

@lguychard
Copy link
Contributor

ability to listen for changes to TextEditor#selections

@sqs investigated this, and it's a bigger change than I expected, notably because there is currently no support for TextEditor#selections on code hosts (selections only work in the web app).

How about doing this through registerHoverProvider for 3.0?

@sqs
Copy link
Member Author

sqs commented Jan 4, 2019

@lguychard It’s OK for there to not be selections from code hosts yet. Bringing back the Git blame on selected line feature for Sourcegraph is good enough.

@sqs sqs removed the release-blocker Prevents us from releasing: https://about.sourcegraph.com/handbook/engineering/releases label Jan 7, 2019
@sqs sqs modified the milestones: 3.0, 3.1 Jan 7, 2019
@sqs sqs removed their assignment Jan 7, 2019
@sqs sqs mentioned this issue Jan 25, 2019
Closed
2 tasks
@sqs
Copy link
Member Author

sqs commented Jan 25, 2019

Filed the extension APIs that are necessary for this in #2026, to keep this purely about updating the git-extras extension to use these new APIs.

@sqs sqs added the extensions Sourcegraph extensions label Jan 25, 2019
@sqs
Copy link
Member Author

sqs commented Jan 30, 2019 •
edited

Dupe of #1113

@sqs sqs closed this as completed Jan 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vanesa vanesa

Labels
extensions Sourcegraph extensions feature-request
Projects
None yet
Milestone
3.1
Development

No branches or pull requests
4 participants
@sqs @lguychard @vanesa @felixfbecker