Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Orphan hovers after navigation #3108

Closed
felixfbecker opened this issue Apr 1, 2019 · 0 comments · Fixed by sourcegraph/codeintellify#102
Closed

Orphan hovers after navigation #3108

felixfbecker opened this issue Apr 1, 2019 · 0 comments · Fixed by sourcegraph/codeintellify#102
Assignees
@lguychard @felixfbecker
Labels
browser-extension bug An error, flaw or fault that produces an incorrect or unexpected result, or behavior.
Projects
Web Team :: Current iteration
Milestone
3.3

Comments

@felixfbecker
Copy link
Contributor

  • Go to PR
  • Pin the hover
  • Click back button

See stuck hover:

image

sourcegraph/codeintellify#100 was supposed to fix this (and has unit tests) so either that fix didn't work, or unsubscribe() is not called properly (which could also be caused by the codeview remove not being detected).
@felixfbecker felixfbecker added bug An error, flaw or fault that produces an incorrect or unexpected result, or behavior. browser-extension labels Apr 1, 2019
@felixfbecker felixfbecker added this to To do in Web Team :: Current iteration via automation Apr 1, 2019
felixfbecker added a commit to sourcegraph/codeintellify that referenced this issue Apr 1, 2019
@felixfbecker
fix: unsubscribe from actions and hover observable
9f5890b 
Only take from the actions and hover Observables until the code view is unsubscribed.

Fixes sourcegraph/sourcegraph#3108
@felixfbecker felixfbecker mentioned this issue Apr 1, 2019
Merged
Web Team :: Current iteration automation moved this from To do to Done Apr 1, 2019
felixfbecker added a commit to sourcegraph/codeintellify that referenced this issue Apr 1, 2019
@felixfbecker
fix: unsubscribe from actions and hover observable (#102)
50263a6 
Only take from the actions and hover Observables until the code view is unsubscribed.

Fixes sourcegraph/sourcegraph#3108
@felixfbecker felixfbecker added this to the 3.3 milestone Apr 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lguychard lguychard

@felixfbecker felixfbecker

Labels
browser-extension bug An error, flaw or fault that produces an incorrect or unexpected result, or behavior.
Projects
No open projects
Web Team :: Current iteration
  
Done
Milestone
3.3
Development

Successfully merging a pull request may close this issue.

fix: unsubscribe from actions and hover observable sourcegraph/codeintellify
2 participants
@lguychard @felixfbecker