Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Accessibility]: Global nav bar: User profile menu usability #35119

Closed
2 of 4 tasks
umpox opened this issue May 9, 2022 · 1 comment · Fixed by #38300
Closed
2 of 4 tasks

[Accessibility]: Global nav bar: User profile menu usability #35119

umpox opened this issue May 9, 2022 · 1 comment · Fixed by #38300
Assignees
Labels
accessibility a11y / accessibility estimate/1d frontend-platform Issues related to our frontend platform, owned collectively by our frontend crew. wcag/2.1/fixing wcag/2.1

Comments

@umpox
Copy link
Contributor

umpox commented May 9, 2022

Audit type

Screen reader navigation

User journey audit issue

#34411

Problem description

Focus styles

image

There isn't a clear blue outline focus when the menu has keyboard focus. It should appear like other elements do, such as the navigation links.

Menu items

When using a screen reader, links only appear as "MenuItem" - they should also read out the href and any other link related information to the user.

Expected behavior

Focus styles

Add clear blue focus outline when selected

Menu items
Ensure screen readers still treat each item as links. Note: we still want a menu item role somewhere, to support keyboard navigation. Maybe we can wrap each menu item in the link.

Additional details

No response

Assigning labels

  • Please give this issue an estimate by applying a label like estimate/Xd, where X is the estimated number of days it will take to complete.
  • If this issue is specific to a specific Sourcegraph product, please assign the appropriate team label to this issue.
  • If this issue will require input from designers in order to complete, please assign the label needs-design.
  • If you are confident that this issue should be fixed by GitStart, please assign the label gitstart.

Owner

This issue will be fixed by my team, I have assigned a relevant member to it, or I will do so in the near future.

@umpox
Copy link
Contributor Author

umpox commented Jun 1, 2022

Might be fixed by #36350

@umpox umpox linked a pull request Jul 6, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility a11y / accessibility estimate/1d frontend-platform Issues related to our frontend platform, owned collectively by our frontend crew. wcag/2.1/fixing wcag/2.1
Projects
Status: Done
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant