Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility: Add focus-visible outline to menus #38300

Merged
merged 3 commits into from Jul 6, 2022
Merged

Conversation

umpox
Copy link
Contributor

@umpox umpox commented Jul 6, 2022

Description

Related to #38298

Until we have a better solution to attaching the correct focus to menu items, this works as an OK workaround to indicate to users where the focus has moved to.

This is only shown for keyboard users

Screenshots

BEFORE AFTER
image image

Test plan

Tested locally with keyboard navigation

App preview:

Check out the client app preview documentation to learn more.

@cla-bot cla-bot bot added the cla-signed label Jul 6, 2022
@github-actions github-actions bot added the frontend-platform Issues related to our frontend platform, owned collectively by our frontend crew. label Jul 6, 2022
@sourcegraph-bot
Copy link
Contributor

sourcegraph-bot commented Jul 6, 2022

Codenotify: Notifying subscribers in OWNERS files for diff 7b64768...303509a.

Notify File(s)
@sourcegraph/frontend-platform-devs client/wildcard/src/components/Menu/MenuList.module.scss
client/wildcard/src/components/Menu/MenuList.tsx
client/wildcard/src/components/NavMenu/snapshots/NavMenu.test.tsx.snap

@umpox umpox enabled auto-merge (squash) July 6, 2022 16:14
@umpox umpox merged commit c7b773c into main Jul 6, 2022
@umpox umpox deleted the tr/menu-focus-outline branch July 6, 2022 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed frontend-platform Issues related to our frontend platform, owned collectively by our frontend crew.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Accessibility]: Global nav bar: User profile menu usability
3 participants