Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Accessibility]: Congratulate users on getting help filling out a form #35196

Open
4 tasks done
Tracked by #31476
efritz opened this issue May 9, 2022 · 4 comments
Open
4 tasks done
Tracked by #31476

[Accessibility]: Congratulate users on getting help filling out a form #35196

efritz opened this issue May 9, 2022 · 4 comments
Assignees
Labels
accessibility a11y / accessibility gitstart Contract partner team/graph Graph Team (previously Code Intel/Language Tools/Language Platform) wcag/2.1/fixing wcag/2.1

Comments

@efritz
Copy link
Contributor

efritz commented May 9, 2022

Audit type

Screen reader navigation

User journey audit issue

#33517

Problem description

Screen Shot 2022-05-09 at 5 29 58 PM

Hitting infer configuration from HEAD does not announce any change in state to the user. Inversely, when the button becomes available on the screen it's also not announced. Its visibility can toggle depending on if the current text area state has changed from the inferred config or not.

Expected behavior

I would expect that the entire contents of the text area on the page changing should be announced in some manner.

Additional details

No response

Assigning labels

  • Please give this issue an estimate by applying a label like estimate/Xd, where X is the estimated number of days it will take to complete.
  • If this issue is specific to a specific Sourcegraph product, please assign the appropriate team label to this issue.
  • If this issue will require input from designers in order to complete, please assign the label needs-design.
  • If you are confident that this issue should be fixed by GitStart, please assign the label gitstart.

Owner

This issue will be fixed by my team, I have assigned a relevant member to it, or I will do so in the near future.

@gitstart-app
Copy link
Contributor

gitstart-app bot commented Jul 7, 2022

Here is the GitStart Ticket for this issue: https://app.gitstart.com/clients/sourcegraph/tickets/SG-35196

@umpox
Copy link
Contributor

umpox commented Jul 7, 2022

@efritz Going to assign this one to GitStart, LMK if you disagree/have already worked on a fix!

@gitstart-sourcegraph I think giving this aria-live="polite" would be a sufficient change to notify users

(sorry I posted this on the wrong issue before 😅 )

@gitstart-sourcegraph gitstart-sourcegraph moved this from To do to In progress in GitStart Work Jul 11, 2022
@macraig
Copy link
Contributor

macraig commented Jul 11, 2022

Closing as identified issues have been completed

@macraig macraig closed this as completed Jul 11, 2022
GitStart Work automation moved this from In progress to Done Jul 11, 2022
@umpox
Copy link
Contributor

umpox commented Jul 12, 2022

Reopening this! cc: @gitstart-sourcegraph This fix should still be relevant

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility a11y / accessibility gitstart Contract partner team/graph Graph Team (previously Code Intel/Language Tools/Language Platform) wcag/2.1/fixing wcag/2.1
Projects
GitStart Work
In review
Status: Done
4 participants