Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: Investigate repo archive corruption #39743

Closed
eseliger opened this issue Aug 1, 2022 · 2 comments · Fixed by sourcegraph/src-cli#817
Closed

src: Investigate repo archive corruption #39743

eseliger opened this issue Aug 1, 2022 · 2 comments · Fixed by sourcegraph/src-cli#817
Assignees
Labels
batch-changes Issues related to Batch Changes bug An error, flaw or fault that produces an incorrect or unexpected result, or behavior. estimate/0.5d estimate/1d src-cli

Comments

@eseliger
Copy link
Member

eseliger commented Aug 1, 2022

During some debugging, I interrupted src-cli and it created a corrupted archive, we should investigate that. Likely we don't write the archive to a tmp file name first before the download is finalized?

✅ Parsing batch spec
✅ Resolving namespace
✅ Preparing container images  █████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████  100%
✅ Set workspace type
✅ Resolved 1 repositories
✅ Found 1 workspaces with steps to execute
✅ Found 0 cached changeset specs; 1 task needs to be executed
⠧  Executing... (0/1, 0 errored)                                                                                                                                        0%
│
└── github.com/sourcegraph/sourcegraph  Downloading archive                                                                                                             2s
^C
❌ Error:
   context canceled


💡 The troubleshooting documentation can help to narrow down the cause of the errors:
   https://docs.sourcegraph.com/batch_changes/references/troubleshooting


➜  src batch preview -workspace bind -clear-cache -clean-archives -f spec.yml
✅ Parsing batch spec
✅ Resolving namespace
✅ Preparing container images  █████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████  100%
✅ Set workspace type
✅ Resolved 1 repositories
✅ Found 1 workspaces with steps to execute
✅ Found 0 cached changeset specs; 1 task needs to be executed
✅ Executing... (1/1, 1 errored)  ██████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████  100%
│
└── github.com/sourcegraph/sourcegraph  creating workspace: unzipping the repository: unzipping the ZIP archive: zip: not a valid zip file                              0s

❌ Error:
   github.com/sourcegraph/sourcegraph:
   creating workspace: unzipping the repository: unzipping the ZIP archive: zip: not a valid zip file
   Log: /tmp/changeset-github.com-sourcegraph-sourcegraph-b0ecedeea63bab9c93f6c2f6f52accd0f63dcd01.3769720950.log



💡 The troubleshooting documentation can help to narrow down the cause of the errors:
   https://docs.sourcegraph.com/batch_changes/references/troubleshooting
@eseliger eseliger added bug An error, flaw or fault that produces an incorrect or unexpected result, or behavior. estimate/0.5d estimate/1d src-cli labels Aug 1, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Aug 1, 2022

Hey, @sourcegraph/batchers (@eseliger @LawnGnome @courier-new @adeola-ak @BolajiOlajide @Piszmog @malomarrec @chrispine @danielmarquespt) - we have been mentioned. Let's take a look.

@eseliger eseliger added the batch-changes Issues related to Batch Changes label Aug 1, 2022
@chrispine
Copy link
Contributor

P0?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
batch-changes Issues related to Batch Changes bug An error, flaw or fault that produces an incorrect or unexpected result, or behavior. estimate/0.5d estimate/1d src-cli
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants