Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: provide recommendations for using rollout window to avoid hitting rate limits #39773

Closed
courier-new opened this issue Aug 1, 2022 · 0 comments · Fixed by #39848
Closed
Assignees
Labels
batch-changes Issues related to Batch Changes docs estimate/0.5d

Comments

@courier-new
Copy link
Contributor

courier-new commented Aug 1, 2022

A customer recently bumped up against the GitHub API rate limit when they configured a rollout window that was much too aggressive (5/second).

Our docs talk about using rollout windows to avoid overwhelming CI systems, but we could make it clearer that you can also use them if you're hitting code host API rate limits, and provide recommendations for sufficiently-relaxed rates (e.g. "use a rate that is no faster than 1/minute") that would not exceed the rate of any one code host.

As noted in the support issue, GitHub also has an undocumented internal object creation limit that produces the "was submitted too quickly" error message, and has a 1 hour cooldown. We should also add a note to help with troubleshooting this, as it has likely impacted other customers before but only recently has had clarity from someone on the GitHub team about it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
batch-changes Issues related to Batch Changes docs estimate/0.5d
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant