Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add guidance for avoiding rate limits & GitHub's internal limit #39848

Merged
merged 2 commits into from
Aug 3, 2022

Conversation

courier-new
Copy link
Contributor

@courier-new courier-new commented Aug 2, 2022

Closes #39773.

Adds guidance around avoiding hitting rate limits when using rollout windows, as well as what it means when you encounter GitHub's cryptic "was submitted too quickly" error (tl;dr sux, plz wait an hour).

I also filed a follow-up issue to maybe try to automatically respect this internal GitHub limit, as it's come up with a couple different customers and it's always confusing.

Test plan

Just a docs change.

@courier-new courier-new added docs batch-changes Issues related to Batch Changes labels Aug 2, 2022
@courier-new courier-new requested a review from a team August 2, 2022 23:45
@courier-new courier-new self-assigned this Aug 2, 2022
@cla-bot cla-bot bot added the cla-signed label Aug 2, 2022
@sourcegraph-bot
Copy link
Contributor

sourcegraph-bot commented Aug 2, 2022

Codenotify: Notifying subscribers in CODENOTIFY files for diff c88b2b8...5f96389.

Notify File(s)
@sourcegraph/delivery doc/admin/config/batch_changes.md

doc/admin/config/batch_changes.md Outdated Show resolved Hide resolved
doc/admin/config/batch_changes.md Show resolved Hide resolved
@courier-new courier-new changed the title Add guidance for avoiding rate limits, GitHub's internal limit docs: add guidance for avoiding rate limits & GitHub's internal limit Aug 3, 2022
@courier-new courier-new merged commit 1eadf5d into main Aug 3, 2022
@courier-new courier-new deleted the kr/rate-limit-note branch August 3, 2022 16:39
courier-new added a commit that referenced this pull request Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
batch-changes Issues related to Batch Changes cla-signed docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs: provide recommendations for using rollout window to avoid hitting rate limits
6 participants