Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sourcegraph.com should use *_CONFIG_FILE via Kubernetes #4156

Closed
slimsag opened this issue May 22, 2019 · 4 comments
Closed

Sourcegraph.com should use *_CONFIG_FILE via Kubernetes #4156

slimsag opened this issue May 22, 2019 · 4 comments
Assignees
@davejrt
Labels
good first issue Good for newcomers sourcegraph.com Issues assocaiated with / unique to sourcegraph.com
Milestone
3.16

Comments

@slimsag
Copy link
Member

slimsag commented May 22, 2019

We can now commit our Sourcegraph.com configuration to our repository using the new *_CONFIG_FILE environment variables. We should also set DISABLE_CONFIG_UPDATES after #4154 is merged.

This would prevent issues like #3966 (comment) from happening again by accident.
@slimsag slimsag added sourcegraph.com Issues assocaiated with / unique to sourcegraph.com distribution labels May 22, 2019
@beyang beyang closed this as completed Apr 8, 2020
@slimsag
Copy link
Member Author

slimsag commented Apr 9, 2020

Still an issue and has bitten us again since this was filed.

@slimsag slimsag reopened this Apr 9, 2020
@beyang beyang added this to the Backlog milestone Apr 9, 2020
@beyang beyang added the good first issue Good for newcomers label Apr 9, 2020
@beyang beyang modified the milestones: Backlog, 3.16 Apr 20, 2020
@beyang beyang mentioned this issue Apr 21, 2020
Closed
47 tasks
@davejrt
Copy link
Contributor

davejrt commented Apr 28, 2020

Closed via PR #2428

@davejrt davejrt closed this as completed Apr 28, 2020
@slimsag slimsag reopened this May 11, 2020
@slimsag
Copy link
Member Author

slimsag commented May 11, 2020

Was this fixed? From a quick glance at our YAML it seems GLOBAL_SETTINGS_FILE is not set

@davejrt
Copy link
Contributor

davejrt commented May 12, 2020 •
edited

@slimsag this was merged this morning, see here

@davejrt davejrt closed this as completed May 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@davejrt davejrt

Labels
good first issue Good for newcomers sourcegraph.com Issues assocaiated with / unique to sourcegraph.com
Projects
None yet
Milestone
3.16
Development

No branches or pull requests
3 participants
@beyang @davejrt @slimsag