Cody bug: disappearing error in Chat #51759
Assignees
Labels
bug
An error, flaw or fault that produces an incorrect or unexpected result, or behavior.
cody/vscode
cody
Comments
abeatrix
added
bug
philipp-spiess
pushed a commit
that referenced
this issue
May 11, 2023
RE: #51759 Issue: error displaying as chat message will disappear all of a sudden without user action I noticed in the current implementation, errors resulted from failed streaming will replace the current assistant message, which would include the previous error message, or things that Cody has already response. This PR includes a fix where we will add the error message ON TOP of the current assistant message instead of overriding it. For example, instead of removing what Cody has replied and replace it with an error message, we now add the error message after what Cody has already answered `Hello! How can I help you?`: <img width="769" alt="image" src="https://github.com/sourcegraph/sourcegraph/assets/68532117/01862761-1aa3-4f33-94f7-6c2849eb78a3"> Other changes include: - Added a new `<ErrorBanner>` component that would show 5 of the last system error messages as a banner in chat UI (instead of 1, which override the previous one). - Now log all system error messages to debug logs (`"cody.debug": true`) view in UI <img width="1683" alt="Screenshot 2023-05-10 at 7 00 43 PM" src="https://github.com/sourcegraph/sourcegraph/assets/68532117/b09f0a27-bf70-4319-9c29-df2b4f5b6bf7"> <img width="622" alt="image" src="https://github.com/sourcegraph/sourcegraph/assets/68532117/ccdfaf57-8a13-49ab-8d85-5611b52f4a8e"> <img width="609" alt="image" src="https://github.com/sourcegraph/sourcegraph/assets/68532117/8a3800ce-c275-4d4d-845e-6306eecc2c91"> ## Test plan <!-- All pull requests REQUIRE a test plan: https://docs.sourcegraph.com/dev/background-information/testing_principles --> See screenshots above
VolhaBakanouskaya
pushed a commit
to VolhaBakanouskaya/sourcegraph-public
that referenced
this issue
Jun 30, 2023
RE: sourcegraph/sourcegraph#51759 Issue: error displaying as chat message will disappear all of a sudden without user action I noticed in the current implementation, errors resulted from failed streaming will replace the current assistant message, which would include the previous error message, or things that Cody has already response. This PR includes a fix where we will add the error message ON TOP of the current assistant message instead of overriding it. For example, instead of removing what Cody has replied and replace it with an error message, we now add the error message after what Cody has already answered `Hello! How can I help you?`: <img width="769" alt="image" src="https://github.com/sourcegraph/sourcegraph/assets/68532117/01862761-1aa3-4f33-94f7-6c2849eb78a3"> Other changes include: - Added a new `<ErrorBanner>` component that would show 5 of the last system error messages as a banner in chat UI (instead of 1, which override the previous one). - Now log all system error messages to debug logs (`"cody.debug": true`) view in UI <img width="1683" alt="Screenshot 2023-05-10 at 7 00 43 PM" src="https://github.com/sourcegraph/sourcegraph/assets/68532117/b09f0a27-bf70-4319-9c29-df2b4f5b6bf7"> <img width="622" alt="image" src="https://github.com/sourcegraph/sourcegraph/assets/68532117/ccdfaf57-8a13-49ab-8d85-5611b52f4a8e"> <img width="609" alt="image" src="https://github.com/sourcegraph/sourcegraph/assets/68532117/8a3800ce-c275-4d4d-845e-6306eecc2c91"> ## Test plan <!-- All pull requests REQUIRE a test plan: https://docs.sourcegraph.com/dev/background-information/testing_principles --> See screenshots above
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
RE: https://sourcegraph.slack.com/archives/C052G9Y5Y8H/p1683740735455709
report by Erik:
The text was updated successfully, but these errors were encountered: