Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show warning to VS Code users if email is not verified on dotcom #51992

Closed
mrnugget opened this issue May 16, 2023 · 0 comments · Fixed by #51870
Closed

Show warning to VS Code users if email is not verified on dotcom #51992

mrnugget opened this issue May 16, 2023 · 0 comments · Fixed by #51870
Assignees

Comments

@mrnugget
Copy link
Contributor

mrnugget commented May 16, 2023

Follow-up to #51706

@mrnugget mrnugget self-assigned this May 16, 2023
mrnugget added a commit that referenced this issue May 17, 2023
This fixes #51992 and
is a follow-up to #51706 to show a nicer message in VS Code in case user
hasn't confirmed their email yet.

It changes how we fetch the authentication status:
- if we're connected to dotcom, we check whether the user has a verified
email
- if we're not connected to dotcom, we skip that

If the user requires and doesn't have a verified email, we show a
different error on the Login page.

There rest of the changes are essentially there to handle config
changes, handle errors that happen at runtime, and login/logout.

**This needs a thorough review**

## Test plan

- See Loom: https://www.loom.com/share/f95a19cd9fd0419798fc888b49245ca0
- Manual testing
VolhaBakanouskaya pushed a commit to VolhaBakanouskaya/sourcegraph-public that referenced this issue Jun 30, 2023
This fixes sourcegraph/sourcegraph#51992 and
is a follow-up to #51706 to show a nicer message in VS Code in case user
hasn't confirmed their email yet.

It changes how we fetch the authentication status:
- if we're connected to dotcom, we check whether the user has a verified
email
- if we're not connected to dotcom, we skip that

If the user requires and doesn't have a verified email, we show a
different error on the Login page.

There rest of the changes are essentially there to handle config
changes, handle errors that happen at runtime, and login/logout.

**This needs a thorough review**

## Test plan

- See Loom: https://www.loom.com/share/f95a19cd9fd0419798fc888b49245ca0
- Manual testing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant