Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Loading a chat from the history view should have it scrolled to the bottom #52889

Closed
toolmantim opened this issue Jun 3, 2023 · 1 comment
Closed

Loading a chat from the history view should have it scrolled to the bottom #52889

toolmantim opened this issue Jun 3, 2023 · 1 comment
Labels
cody/vscode cody

Comments

@toolmantim
Copy link
Contributor

When navigating to a past chat, it should be scrolled down the bottom to the most recent point, but instead it's at the top (the very start of the conversation).

Screen.Recording.2023-06-03.at.2.11.00.pm.mov

Steps to reproduce:

  1. Send enough messages that you have a scrollable chat window
  2. Hit new chat
  3. Go to the chat history
  4. Click on the history item for the long chat
  5. Notice the scroll position is at the top instead of the bottom

Expected behavior:

The scroll position would be at the bottom
@deepak2431 deepak2431 mentioned this issue Jun 6, 2023
Merged
@abeatrix abeatrix mentioned this issue Jun 8, 2023
Closed
philipp-spiess added a commit that referenced this issue Jun 12, 2023
@deepak2431 @philipp-spiess
Cody: Improve chat history (#52904)
b17c0d6 
This PR closes #52544,  #52848, #52889 and #52890.

The issues mostly overlapped, so I handled it in this PR.

Changes made:
1. Add history to the history list on each new conversation started.
2. Display the last human message in history instead of the assistant
message.
3. Add a delete button to delete individual chats from history.
4. Load the most recent chat, if available, from the history.
5. Fix the loading of context files.
6. Load the history messages to the end of the scroll position.

## Test plan

All E2E tests have passed.
https://www.loom.com/share/3dca98dd0db94c298df38ab79c5e72d1

---------

Co-authored-by: Philipp Spiess <hello@philippspiess.com>
@SuperAuguste
Copy link
Contributor

Closed in #52904.

ErikaRS pushed a commit that referenced this issue Jun 22, 2023
@deepak2431 @philipp-spiess @ErikaRS
Cody: Improve chat history (#52904)
cc3b004 
This PR closes #52544,  #52848, #52889 and #52890.

The issues mostly overlapped, so I handled it in this PR.

Changes made:
1. Add history to the history list on each new conversation started.
2. Display the last human message in history instead of the assistant
message.
3. Add a delete button to delete individual chats from history.
4. Load the most recent chat, if available, from the history.
5. Fix the loading of context files.
6. Load the history messages to the end of the scroll position.

## Test plan

All E2E tests have passed.
https://www.loom.com/share/3dca98dd0db94c298df38ab79c5e72d1

---------

Co-authored-by: Philipp Spiess <hello@philippspiess.com>
@umpox umpox mentioned this issue Jun 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cody/vscode cody
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@toolmantim @SuperAuguste