Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Discrepancy in reported repository count between admin and non-admin users #5318

Closed
beyang opened this issue Aug 21, 2019 · 1 comment · Fixed by #7363
Closed

Discrepancy in reported repository count between admin and non-admin users #5318

beyang opened this issue Aug 21, 2019 · 1 comment · Fixed by #7363
Labels
good first issue Good for newcomers
Milestone
Backlog

Comments

@beyang
Copy link
Member

beyang commented Aug 21, 2019

Reported by https://app.hubspot.com/contacts/2762526/company/554338610.

Repro:

  • Visit /explore as a normal user and admin user
  • In the “Repositories" section, a normal user just sees 4 repos and doesn't see the "view all" link at the bottom:
    image
  • An admin user sees the link, and can click to see all 7 repositories

No repository permissions have been configured on this instance.
@beyang beyang self-assigned this Aug 21, 2019
@beyang beyang added this to the 3.8 milestone Aug 21, 2019
@beyang beyang modified the milestones: 3.8, 3.9 Sep 16, 2019
@tsenart
Copy link
Contributor

tsenart commented Oct 14, 2019

Dear all,

This is your release captain speaking. 🚂🚂🚂

Branch cut for the 3.9 release is scheduled for tomorrow at 10:00 CEST.

Is this issue / PR going to make it in time? Please change the milestone accordingly.
When in doubt, reach out!

Thank you

@beyang beyang modified the milestones: 3.9, 3.10, Backlog Oct 14, 2019
@beyang beyang added the good first issue Good for newcomers label Oct 19, 2019
@beyang beyang removed their assignment Oct 19, 2019
sqs added a commit that referenced this issue Dec 23, 2019
@sqs
remove explore page
ba1333e 
The explore page (at `/explore`) showed recommended extensions based on a hardcoded list, selected Sourcegraph editor/browser/CLI integrations, and a few repositories on the instance. It was intended to be a good place for users to visit to get set up with Sourcegraph. In practice, we never promoted it to users, never included it in our demo paths, and never spent any time maintaining it. We also never heard from users that it was helpful (or not). Based on this (intuition suggests it's not useful + lack of data to suggest otherwise), we should remove it.

Its intent is good and we should find a good way to accomplish its goals in the product, but good intent is not enough for a product feature to stick around (especially when it occupies a prominent link in the global nav).

- fix #5318
- fix #4019
@sqs sqs mentioned this issue Dec 23, 2019
Merged
sqs added a commit that referenced this issue Dec 25, 2019
@sqs
remove explore page
fadbb08 
The explore page (at `/explore`) showed recommended extensions based on a hardcoded list, selected Sourcegraph editor/browser/CLI integrations, and a few repositories on the instance. It was intended to be a good place for users to visit to get set up with Sourcegraph. In practice, we never promoted it to users, never included it in our demo paths, and never spent any time maintaining it. We also never heard from users that it was helpful (or not). Based on this (intuition suggests it's not useful + lack of data to suggest otherwise), we should remove it.

Its intent is good and we should find a good way to accomplish its goals in the product, but good intent is not enough for a product feature to stick around (especially when it occupies a prominent link in the global nav).

- fix #5318
- fix #4019
sqs added a commit that referenced this issue Dec 28, 2019
@sqs
remove explore page
be1b05a 
The explore page (at `/explore`) showed recommended extensions based on a hardcoded list, selected Sourcegraph editor/browser/CLI integrations, and a few repositories on the instance. It was intended to be a good place for users to visit to get set up with Sourcegraph. In practice, we never promoted it to users, never included it in our demo paths, and never spent any time maintaining it. We also never heard from users that it was helpful (or not). Based on this (intuition suggests it's not useful + lack of data to suggest otherwise), we should remove it.

Its intent is good and we should find a good way to accomplish its goals in the product, but good intent is not enough for a product feature to stick around (especially when it occupies a prominent link in the global nav).

- fix #5318
- fix #4019
sqs added a commit that referenced this issue Sep 24, 2020
@sqs
remove explore page
e07692e 
The explore page (at `/explore`) showed recommended extensions based on a hardcoded list, selected Sourcegraph editor/browser/CLI integrations, and a few repositories on the instance. It was intended to be a good place for users to visit to get set up with Sourcegraph. In practice, we never promoted it to users, never included it in our demo paths, and never spent any time maintaining it. We also never heard from users that it was helpful (or not). Based on this (intuition suggests it's not useful + lack of data to suggest otherwise), we should remove it.

Its intent is good and we should find a good way to accomplish its goals in the product, but good intent is not enough for a product feature to stick around (especially when it occupies a prominent link in the global nav).

- fix #5318
- fix #4019
@sqs sqs closed this as completed in #7363 Sep 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
Backlog
Development

Successfully merging a pull request may close this issue.

remove explore page sourcegraph/sourcegraph
2 participants
@tsenart @beyang