Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Browser extension not working when sourcegraphURL has a trailing slash #6521

Closed
lguychard opened this issue Nov 9, 2019 · 6 comments · Fixed by #10443
Closed

Browser extension not working when sourcegraphURL has a trailing slash #6521

lguychard opened this issue Nov 9, 2019 · 6 comments · Fixed by #10443
Assignees
@lguychard @felixfbecker
Labels
browser-extension bug An error, flaw or fault that produces an incorrect or unexpected result, or behavior. estimate/1d
Projects
Web Team :: Current iteration
Milestone
3.16

Comments

@lguychard
Copy link
Contributor

Works correctly when there is no trailing slash:
image

Fails with unhelpful hints when there is a trailing slash:
image

We should gracefully handle the URL containing a trailing slash, or at the very least tell the user what the actual issue is.
@lguychard lguychard added bug An error, flaw or fault that produces an incorrect or unexpected result, or behavior. browser-extension labels Nov 9, 2019
@felixfbecker
Copy link
Contributor

The options page should use new URL() to validate and canonicalize the URL

@felixfbecker felixfbecker added this to To do in Web Team :: Current iteration via automation Nov 9, 2019
@lguychard
Copy link
Contributor Author

This would also help not mishandling the URL: #3990

@lguychard lguychard mentioned this issue Nov 9, 2019
Closed
@dadlerj
Copy link
Member

dadlerj commented Apr 15, 2020

Reported by a user at https://app.hubspot.com/contacts/2762526/company/557476528 that ran into this today: https://sourcegraph.slack.com/archives/C0117QDJACU/p1586987397001600

@felixfbecker
Copy link
Contributor

https://app.hubspot.com/contacts/2762526/company/974120254 ran into this as well, https://sourcegraph.slack.com/archives/CMT39K56Z/p1587159903175600?thread_ts=1586798352.127800&cid=CMT39K56Z

@lguychard lguychard added this to the 3.16 milestone Apr 28, 2020
@lguychard lguychard mentioned this issue Apr 28, 2020
Closed
41 tasks
@dadlerj
Copy link
Member

dadlerj commented May 5, 2020

Just hit by another user at https://app.hubspot.com/contacts/2762526/company/557476528 a moment ago

lguychard pushed a commit that referenced this issue May 6, 2020
Use URL constsructor to build API URLs
acd6dbe 
Fixes #6521

Avoids building invalid URLs when the base Sourcegraph URL has a trailing slash, across all platforms (browser extension, native integrations).
@lguychard lguychard mentioned this issue May 6, 2020
Merged
Web Team :: Current iteration automation moved this from To do to Done May 6, 2020
lguychard pushed a commit that referenced this issue May 6, 2020
Use URL constsructor to build API URLs (#10443)
b7a3e15 
Fixes #6521

Avoids building invalid URLs when the base Sourcegraph URL has a trailing slash, across all platforms (browser extension, native integrations).
@lguychard
Copy link
Contributor Author

Fixed in browser extension v20.5.6.835. For native integrations, the fix will roll out in 3.16.

@sourcegraph-bot sourcegraph-bot mentioned this issue Dec 8, 2020
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lguychard lguychard

@felixfbecker felixfbecker

Labels
browser-extension bug An error, flaw or fault that produces an incorrect or unexpected result, or behavior. estimate/1d
Projects
No open projects
Web Team :: Current iteration
  
Done
Milestone
3.16
3 participants
@lguychard @dadlerj @felixfbecker