Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syntax highlighting for diff hunks #9166

Closed
eseliger opened this issue Mar 19, 2020 · 3 comments · Fixed by #10437
Closed

Syntax highlighting for diff hunks #9166

eseliger opened this issue Mar 19, 2020 · 3 comments · Fixed by #10437
Assignees
Labels
batch-changes Issues related to Batch Changes estimate/1.5d planned/3.16 Issues that were planned for the given milestone. Used by cmd/tracking-issue. webapp
Milestone

Comments

@eseliger
Copy link
Member

eseliger commented Mar 19, 2020

Implement syntax highlighting for diff hunks. As we use diff views more and more with campaigns really coming together, I'm feeling that proper syntax highlighting here would add a ton of value.

While hacking something together using highlightjs in the DiffHunk component, it became clear that this adds a high value in legibility.

Before:
image

After:
image

@slimsag
Copy link
Member

slimsag commented Apr 9, 2020

This should really be done with our backend syntax highlighter and not highlightjs

@eseliger
Copy link
Member Author

eseliger commented Apr 9, 2020

That’s the plan the screenshot was just to verify how much value it adds

@mrnugget mrnugget added this to the 3.16 milestone Apr 16, 2020
@mrnugget
Copy link
Contributor

I'll take this on in 3.16, timeboxed, because I'm not sure yet what's involved.

@lguychard lguychard mentioned this issue Apr 16, 2020
41 tasks
@felixfbecker felixfbecker moved this from To do to Next in Web Team :: Current iteration Apr 20, 2020
@tsenart tsenart added the planned/3.16 Issues that were planned for the given milestone. Used by cmd/tracking-issue. label Apr 28, 2020
@mrnugget mrnugget removed their assignment May 6, 2020
Web Team :: Current iteration automation moved this from Next to Done May 12, 2020
@chrispine chrispine added the batch-changes Issues related to Batch Changes label Aug 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
batch-changes Issues related to Batch Changes estimate/1.5d planned/3.16 Issues that were planned for the given milestone. Used by cmd/tracking-issue. webapp
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

5 participants