Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

observability: Improve ping logging #9866

Closed
slimsag opened this issue Apr 14, 2020 · 2 comments · Fixed by #11504
Closed

observability: Improve ping logging #9866

slimsag opened this issue Apr 14, 2020 · 2 comments · Fixed by #11504
Assignees
@daxmc99
Labels
bug An error, flaw or fault that produces an incorrect or unexpected result, or behavior. debugging estimate/0.5d important planned/3.16 Issues that were planned for the given milestone. Used by cmd/tracking-issue. planned/3.17
Projects
OLD - Distribution - use "Distributio...
Milestone
3.17

Comments

@slimsag
Copy link
Member

slimsag commented Apr 14, 2020

https://sourcegraph.com/github.com/sourcegraph/sourcegraph@855765631d4c8236ed6f5efcc7a356ffca9a84fa/-/blob/cmd/frontend/internal/app/pkg/updatecheck/client.go#L139-220

All of the logs in this function should have a proper prefix. Right now you must manually search frontend logs for each one, which is a huge pain and made debugging https://sourcegraph.slack.com/archives/CMB6K7SMN/p1586814349064400 really hard.
@slimsag slimsag added bug An error, flaw or fault that produces an incorrect or unexpected result, or behavior. team/distribution debugging labels Apr 14, 2020
@slimsag slimsag added this to the 3.16 milestone Apr 14, 2020
@slimsag slimsag self-assigned this Apr 14, 2020
@beyang beyang mentioned this issue Apr 21, 2020
Closed
47 tasks
@slimsag slimsag changed the title improve ping logging **STRETCH:** improve ping logging Apr 24, 2020
@uwedeportivo
Copy link
Contributor

Dear all,

This is your release captain speaking. 🚂🚂🚂

Branch cut for the 3.16 release is scheduled for tomorrow.

Is this issue / PR going to make it in time? Please change the milestone accordingly.
When in doubt, reach out!

Thank you

@slimsag slimsag modified the milestones: 3.16, 3.17 May 15, 2020
@slimsag slimsag added the planned/3.16 Issues that were planned for the given milestone. Used by cmd/tracking-issue. label May 15, 2020
@slimsag slimsag mentioned this issue May 18, 2020
Closed
37 tasks
@slimsag slimsag changed the title **STRETCH:** improve ping logging Improve ping logging May 18, 2020
@slimsag slimsag changed the title Improve ping logging observability: Improve ping logging May 18, 2020
@daxmc99 daxmc99 self-assigned this May 22, 2020
@slimsag slimsag removed their assignment Jun 3, 2020
@slimsag slimsag moved this from Needs triage to To do in OLD - Distribution - use "Distribution 🚢" Jun 3, 2020
@daxmc99 daxmc99 mentioned this issue Jun 15, 2020
Merged
@uwedeportivo
Copy link
Contributor

Dear all,

This is your release captain speaking. 🚂🚂🚂

Branch cut for the 3.17 release is scheduled for tomorrow.

Is this issue / PR going to make it in time? Please change the milestone accordingly.
When in doubt, reach out!

Thank you

OLD - Distribution - use "Distribution 🚢" automation moved this from To do to Done Jun 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@daxmc99 daxmc99

Labels
bug An error, flaw or fault that produces an incorrect or unexpected result, or behavior. debugging estimate/0.5d important planned/3.16 Issues that were planned for the given milestone. Used by cmd/tracking-issue. planned/3.17
Projects
No open projects
OLD - Distribution - use "Distributio...
Done
Milestone
3.17
Development

Successfully merging a pull request may close this issue.

Add telemetry prefix to ping logs sourcegraph/sourcegraph
3 participants
@uwedeportivo @slimsag @daxmc99