Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix browser extension e2e tests #10075

Merged
merged 1 commit into from
Apr 21, 2020
Merged

Fix browser extension e2e tests #10075

merged 1 commit into from
Apr 21, 2020

Conversation

felixfbecker
Copy link
Contributor

This was broken because language servers were disabled on sourcegraph.com, and we now have a less precise multi-definition result from basic code intel. This updates the URLs to that.

@felixfbecker felixfbecker requested a review from a team as a code owner April 21, 2020 09:27
@felixfbecker felixfbecker requested a review from a team April 21, 2020 09:27
@felixfbecker felixfbecker removed the request for review from a team April 21, 2020 09:27
Copy link
Member

@eseliger eseliger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Procfile not intended, is it? 😄

@felixfbecker
Copy link
Contributor Author

Trying to save my laptop from melting 😄

@felixfbecker felixfbecker added browser-extension testing Issues that deal with unit tests, integration tests and the testing infrastructure. labels Apr 21, 2020
@felixfbecker felixfbecker added this to Needs review in Web Team :: Current iteration via automation Apr 21, 2020
@codecov
Copy link

codecov bot commented Apr 21, 2020

Codecov Report

Merging #10075 into master will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master   #10075      +/-   ##
==========================================
- Coverage   42.78%   42.78%   -0.01%     
==========================================
  Files        1348     1348              
  Lines       74027    74028       +1     
  Branches     6651     6651              
==========================================
  Hits        31670    31670              
- Misses      39496    39497       +1     
  Partials     2861     2861              
Flag Coverage Δ
#unit 42.78% <0.00%> (-0.01%) ⬇️
Impacted Files Coverage Δ
browser/src/e2e/shared.ts 0.00% <0.00%> (ø)

@felixfbecker felixfbecker merged commit 1ddce11 into master Apr 21, 2020
Web Team :: Current iteration automation moved this from Needs review to Done Apr 21, 2020
@felixfbecker felixfbecker deleted the bext-e2e-quick-fix branch April 21, 2020 09:57
@felixfbecker felixfbecker mentioned this pull request Apr 28, 2020
41 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
browser-extension testing Issues that deal with unit tests, integration tests and the testing infrastructure.
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants