dev/watchman: merge file change events while running handle changed #10119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a refactor to make the next commit clearer. There should be no functionality change introduced by this commit.
Watchman only sends file change events once the FS is settled. However, it isn't aware of our handleChanged process, so if a dev is still saving files while the compiler is running the events would queue up. This would lead to our watchman wrapper running handle changed several times. We now dedup the watch events while the compilation is running before calling it again.
67 tasks
Codecov Report
@@ Coverage Diff @@
## master #10119 +/- ##
=======================================
Coverage 42.75% 42.75%
=======================================
Files 1348 1348
Lines 74123 74123
Branches 6651 6651
=======================================
Hits 31690 31690
Misses 39571 39571
Partials 2862 2862
|
unknwon
approved these changes
Apr 22, 2020
|
Thanks for improving this 😭 |
mrnugget
approved these changes
Apr 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Watchman only sends file change events once the FS is settled. However, it
isn't aware of our handleChanged process, so if a dev is still saving files
while the compiler is running the events would queue up. This would lead to
our watchman wrapper running handle changed several times. We now dedup the
watch events while the compilation is running before calling it again.