Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set smartSearchField feature flag to on by default #10648

Merged
merged 7 commits into from May 14, 2020

Conversation

lguychard
Copy link
Contributor

Prerequisites: #10647, #10636

Switches smartSearchField to true by default, fixes relevant regression tests and adds changelog entry.

cc @christinaforney

@lguychard lguychard requested a review from a team May 13, 2020 21:14
@lguychard lguychard requested a review from a team as a code owner May 13, 2020 21:14
@lguychard lguychard requested a review from a team May 13, 2020 21:14
Copy link
Contributor

@uwedeportivo uwedeportivo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the e2e touchups 👍 !!

Copy link
Member

@unknwon unknwon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve for the parts owned by core services.

web/src/regression/search.test.ts Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented May 14, 2020

Codecov Report

Merging #10648 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #10648   +/-   ##
=======================================
  Coverage   44.74%   44.74%           
=======================================
  Files        1344     1344           
  Lines       76109    76109           
  Branches     6543     6543           
=======================================
  Hits        34053    34053           
  Misses      38805    38805           
  Partials     3251     3251           
Flag Coverage Δ
#go 48.32% <0.00%> (ø)
#storybook 5.61% <0.00%> (ø)
#typescript 35.59% <0.00%> (ø)
#unit 44.55% <0.00%> (ø)

@lguychard lguychard merged commit 79b3ad2 into master May 14, 2020
@lguychard lguychard deleted the lg/enable-smart-search-by-default branch May 14, 2020 13:51
@lguychard lguychard mentioned this pull request May 18, 2020
23 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants