Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

authz: add docs and links to background permissions syncing #10971

Merged
merged 1 commit into from May 28, 2020

Conversation

unknwon
Copy link
Member

@unknwon unknwon commented May 26, 2020

Adds a section in docs to explain "complete sync vs incremental sync", and adds links to docs in corresponding pages.

Fixes #10190

@unknwon unknwon requested review from a team May 26, 2020 01:45
@ryan-blunden
Copy link
Contributor

If I understand this correctly, a "complete sync" is only done once at the start, either when a repository or user is first added? Then an incremental sync is just reflecting any changes in permissions that have happened since then to bring Sourcegraph up-to-date with the code host?

If that' the case, I would try adjusting the content here to explain the sequence of when each type of sync happens, and in the case of an incremental sync, what would trigger an incremental sync?

@unknwon
Copy link
Member Author

unknwon commented May 26, 2020

If I understand this correctly, a "complete sync" is only done once at the start, either when a repository or user is first added? Then an incremental sync is just reflecting any changes in permissions that have happened since then to bring Sourcegraph up-to-date with the code host?

Hmm... a "complete sync" is what happens periodically, which has side effect of triggering many incremental syncs to reflect any permissions changed since last "complete sync" of those affected repositories or users.

@unknwon
Copy link
Member Author

unknwon commented May 28, 2020

Merging as-is, happy to address any post-merge comments!

@unknwon unknwon merged commit 04d1677 into master May 28, 2020
@unknwon unknwon deleted the jc/update-perms-docs branch May 28, 2020 03:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs: How background permissions syncing works
2 participants