Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

codeintel: Replace SQLite with dgraph-io/badger #11052

Closed
wants to merge 3 commits into from

Conversation

efritz
Copy link
Contributor

@efritz efritz commented May 28, 2020

No description provided.

@codecov
Copy link

codecov bot commented May 28, 2020

Codecov Report

Merging #11052 into tar-bundle-payloads will not change coverage.
The diff coverage is n/a.

@@                 Coverage Diff                  @@
##           tar-bundle-payloads   #11052   +/-   ##
====================================================
  Coverage                46.34%   46.34%           
====================================================
  Files                     1374     1374           
  Lines                    77412    77412           
  Branches                  6595     6595           
====================================================
  Hits                     35875    35875           
  Misses                   38130    38130           
  Partials                  3407     3407           
Flag Coverage Δ
#go 50.38% <0.00%> (ø)
#storybook 6.88% <0.00%> (ø)
#typescript 35.84% <0.00%> (ø)
#unit 46.13% <0.00%> (ø)

@unknwon
Copy link
Member

unknwon commented May 28, 2020

Is there an RFC for this change?

The default memory footprint of badger is not small. Also it requires 64-bits system to compile (even though they claimed fixed this many times but I couldn't compile it on a 32-bit machine as of Jan or Feb this year).

@efritz
Copy link
Contributor Author

efritz commented May 28, 2020

Is there an RFC for this change?

No, this is just an experiment. I plan to do measurements with a handful of different storage mechanisms and serialization techniques.

The default memory footprint of badger is not small. Also it requires 64-bits system to compile (even though they claimed fixed this many times but I couldn't compile it on a 32-bit machine as of Jan or Feb this year).

I'll do additional profiling to see if I can get it down. Is it necessary to compile on a 32-bit machine?

@efritz efritz changed the base branch from master to tar-bundle-payloads May 28, 2020 19:40
@efritz efritz closed this May 29, 2020
@efritz efritz deleted the bundle-badger-store branch June 1, 2020 22:49
Copy link
Member

@keegancsmith keegancsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@efritz I think sqlite is just really good at immutable data stores? When you benchmarked the performance, where did the issues lie? Is it possible it is just that we are always dominated by serialization so it doesn't really matter what the underlying store is?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants