Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove reload flag from dev script #12277

Merged
merged 1 commit into from Jul 16, 2020
Merged

remove reload flag from dev script #12277

merged 1 commit into from Jul 16, 2020

Conversation

davejrt
Copy link
Contributor

@davejrt davejrt commented Jul 16, 2020

This flag is now build into the container image via #12211

@davejrt davejrt requested a review from a team July 16, 2020 22:46
@codecov
Copy link

codecov bot commented Jul 16, 2020

Codecov Report

Merging #12277 into master will increase coverage by 1.64%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #12277      +/-   ##
==========================================
+ Coverage   49.41%   51.06%   +1.64%     
==========================================
  Files        1411     1425      +14     
  Lines       80510    81124     +614     
  Branches     6614     6680      +66     
==========================================
+ Hits        39786    41423    +1637     
+ Misses      37103    36076    -1027     
- Partials     3621     3625       +4     
Flag Coverage Δ
#go 52.57% <ø> (-0.01%) ⬇️
#integration 24.03% <ø> (ø)
#storybook 12.13% <ø> (ø)
#typescript 47.01% <ø> (+6.30%) ⬆️
#unit 47.77% <ø> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../internal/codeintel/resolvers/graphql/locations.go 85.45% <0.00%> (-1.82%) ⬇️
browser/src/shared/cli/search.ts 0.00% <0.00%> (ø)
browser/src/shared/code-hosts/shared/codeHost.tsx 57.40% <0.00%> (ø)
...src/browser-extension/scripts/optionsPage.main.tsx 0.00% <0.00%> (ø)
...rowser-extension/options-page/OptionsContainer.tsx 82.14% <0.00%> (ø)
browser/src/shared/components/SourcegraphIcon.tsx 100.00% <0.00%> (ø)
browser/src/shared/components/ShortcutProvider.tsx 0.00% <0.00%> (ø)
...wser/src/shared/code-hosts/shared/SignInButton.tsx 41.66% <0.00%> (ø)
...ared/code-hosts/shared/ViewOnSourcegraphButton.tsx 80.00% <0.00%> (ø)
...rowser/src/shared/code-hosts/shared/extensions.tsx 81.94% <0.00%> (ø)
... and 63 more

@davejrt davejrt merged commit ea795bb into master Jul 16, 2020
@davejrt davejrt deleted the dave/prometheus_flag branch July 16, 2020 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants