search: add NOT as syntactic sugar #12520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rvantonder
reviewed
Jul 28, 2020
rvantonder
reviewed
Jul 28, 2020
rvantonder
reviewed
Jul 28, 2020
rvantonder
reviewed
Jul 28, 2020
rvantonder
reviewed
Jul 28, 2020
rvantonder
reviewed
Jul 28, 2020
rvantonder
reviewed
Jul 28, 2020
rvantonder
reviewed
Jul 28, 2020
rvantonder
approved these changes
Jul 28, 2020
stefanhengl
force-pushed
the
sh/not-as-syntactic-suggar
branch
from
abd6d13
to
987aada
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9976, relates to RFC94
This PR adds NOT as syntactic sugar to our query syntax. We support NOT for all negatable fields. If NOT comes before an unsupported field, we wrap the operand in a negated content field.
Examples
not file:foo-file:foonot repo:foo-repo:foonot content:foo-content:foonot foo-content:foonot foo:bar(unknown keyword)-content:"foo:bar"