Use static lists of columns in campaigns.Store methods #12714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrnugget
force-pushed
the
mrn/store-fixes
branch
from
290c81e
to
bb4998c
Compare
mrnugget
force-pushed
the
mrn/column-lists
branch
from
1199eed
to
5474157
Compare
eseliger
approved these changes
Aug 4, 2020
LawnGnome
approved these changes
Aug 4, 2020
mrnugget
force-pushed
the
mrn/column-lists
branch
from
5474157
to
fd35748
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The diff stat says that not a lot of code was deleted, but I prefer having two places in which I need to add/remove columns than 4.