Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

codeintel: RFC 235: Migrate SQLite data to Postgres #13932

Merged
merged 12 commits into from Oct 7, 2020
Merged

Conversation

efritz
Copy link
Contributor

@efritz efritz commented Sep 17, 2020

A step towards RFC 235: Move LSIF data to Postgres. Closes #13888.

This PR migrates existing data to the Postgres-backed bundle store introduced #13923. Do not merge this PR until #13924 has been completed and deployed.

@efritz efritz added team/graph Graph Team (previously Code Intel/Language Tools/Language Platform) RFC-235 labels Sep 17, 2020
@efritz efritz self-assigned this Sep 17, 2020
@efritz efritz changed the base branch from main to ef/postgres-store September 17, 2020 22:52
@codecov
Copy link

codecov bot commented Sep 17, 2020

Codecov Report

Merging #13932 into ef/postgres-store will not change coverage.
The diff coverage is n/a.

@@                Coverage Diff                 @@
##           ef/postgres-store   #13932   +/-   ##
==================================================
  Coverage              48.10%   48.10%           
==================================================
  Files                   1553     1553           
  Lines                  78993    78993           
  Branches                7014     7014           
==================================================
  Hits                   38001    38001           
  Misses                 37263    37263           
  Partials                3729     3729           
Flag Coverage Δ *Carryforward flag
#go 52.33% <0.00%> (ø)
#storybook 18.13% <0.00%> (ø) Carriedforward from a0a918b
#typescript 37.87% <0.00%> (ø) Carriedforward from a0a918b
#unit 33.87% <0.00%> (ø) Carriedforward from a0a918b

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
internal/db/helpers.go 100.00% <0.00%> (ø)
internal/gosrc/stdlib.go 100.00% <0.00%> (ø)
internal/conf/platform.go 100.00% <0.00%> (ø)
internal/routevar/util.go 100.00% <0.00%> (ø)
internal/timeutil/week.go 100.00% <0.00%> (ø)
internal/vcs/git/mocks.go 100.00% <0.00%> (ø)
internal/db/query/query.go 100.00% <0.00%> (ø)
internal/highlight/mocks.go 100.00% <0.00%> (ø)
internal/routevar/regexp.go 100.00% <0.00%> (ø)
cmd/searcher/search/lower.go 100.00% <0.00%> (ø)
... and 766 more

@efritz efritz requested a review from a team September 18, 2020 18:07
@efritz efritz added this to the 3.21 milestone Sep 18, 2020
@efritz efritz marked this pull request as ready for review October 6, 2020 02:50
@sourcegraph-bot
Copy link
Contributor

sourcegraph-bot commented Oct 6, 2020

Notifying subscribers in CODENOTIFY files for diff f2dbbda...f4349bd.

Notify File(s)
@beyang enterprise/cmd/precise-code-intel-bundle-manager/internal/readers/migrate.go
enterprise/cmd/precise-code-intel-bundle-manager/main.go
@sourcegraph/code-intelligence enterprise/cmd/precise-code-intel-bundle-manager/internal/readers/migrate.go
enterprise/cmd/precise-code-intel-bundle-manager/main.go

Copy link
Member

@Strum355 Strum355 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At most maybe wrap the errors from migrateToPostgres rather than passing up raw errors, otherwise LGTM :)

Base automatically changed from ef/postgres-store to main October 6, 2020 21:26
@efritz efritz merged commit 1abab1f into main Oct 7, 2020
@efritz efritz deleted the ef/migrate-to-postgres branch October 7, 2020 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team/graph Graph Team (previously Code Intel/Language Tools/Language Platform)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RFC 235: Migrate SQLite data to Postgres
3 participants