Fix blob viewer Percy flake

[tjkandala]

I saw a Percy snapshot for 'shows a hover overlay from a hover provider' in which InstallBrowserExtensionAlert was displayed. I'm not sure how that happened (could it have ran after the 'browser extension discoverability' block?).

This will be a short-lived fix, since we'll be able to disable the discoverability features in commonWebGraphQlResults soon.

[tjkandala]

Evidence:

[codecov]

Codecov Report

Merging #14694 into main will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main   #14694   +/-   ##
=======================================
  Coverage   52.21%   52.21%           
=======================================
  Files        1556     1556           
  Lines       79150    79150           
  Branches     6947     7016   +69     
=======================================
+ Hits        41330    41331    +1     
+ Misses      34084    34081    -3     
- Partials     3736     3738    +2     

Flag	Coverage Δ
#go	52.53% <ø> (-0.01%)	⬇️
#integration	30.80% <ø> (+0.01%)	⬆️
#storybook	22.02% <ø> (ø)
#typescript	51.45% <ø> (+<0.01%)	⬆️
#unit	33.23% <ø> (ø)

Impacted Files	Coverage Δ
.../internal/codeintel/resolvers/graphql/locations.go	83.50% <0.00%> (-2.07%)	⬇️
cmd/frontend/graphqlbackend/zoekt.go	74.80% <0.00%> (+0.25%)	⬆️
...ient/web/src/search/input/LazyMonacoQueryInput.tsx	100.00% <0.00%> (+22.22%)	⬆️

[felixfbecker]

I just ran into this flakiness too and filed #14939

What do you mean with this?

This will be a short-lived fix, since we'll be able to disable the discoverability features in commonWebGraphQlResults soon.

[tjkandala]

What do you mean with this?

I was under the impression that alerts.codeHostIntegrationMessaging would include a none option as well, to disable it in all tests outside of the the browser extension discoverability block. Since it doesn't, I'm happy with this fix. I'll merge upon approval

[felixfbecker]

This looks like a band-aid fix that only applies to this specific test. The root cause here seems to be that a previous test primes the localStorage so that the alert is shown on the next test. Tests should be isolated. Instead of adding this code to the test, we should be using beforeEach() to clear localStorage entirely before each test. Ideally even in createIntegrationTestContext() if there are no side effects of that.

[tjkandala]

I'm working on a better solution in #15037 that works locally, but still results in the browser extension alert appearing in Percy. Since this is getting to be really annoying, and this PR should fix this issue for the only test it's a problem for right now, should we merge this for now?

[felixfbecker]

Sounds good