Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The identifier information popup doesn't consistently appear #147

Closed
neongreen opened this issue Sep 19, 2018 · 5 comments
Closed

The identifier information popup doesn't consistently appear #147

neongreen opened this issue Sep 19, 2018 · 5 comments
Assignees
Labels
bug An error, flaw or fault that produces an incorrect or unexpected result, or behavior. team/graph Graph Team (previously Code Intel/Language Tools/Language Platform)
Milestone

Comments

@neongreen
Copy link

  • Sourcegraph version: Sourcegraph.com

  • Platform: Vivaldi 1.15.1147.64 (Blink), Linux

Steps to reproduce:

  1. Install the Chrome extension

  2. Enable the Haskell Sourcegraph extension

  3. Go to https://github.com/wireapp/wire-server/pull/469/files and hover over a bunch of identifiers

Full list of extensions I have enabled ```json { "extensions": { "langserver/typescript": true, "langserver/bash": true, "langserver/clojure": true, "langserver/cpp": true, "langserver/cs": true, "langserver/css": true, "langserver/go": true, "langserver/java": true, "langserver/html": true, "langserver/javascript": true, "langserver/lua": true, "langserver/ocaml": true, "langserver/php": true, "langserver/python": true, "langserver/r": true, "langserver/ruby": true, "langserver/rust": true, "langserver/swift": true, "sourcegraph/codecov": true, "langserver/haskell": true, "langserver/dockerfile": true }, "basicCodeIntel.enabled": false } ```

Expected:

A popup should appear!

Actual:

After like 10 hovers the popup stops appearing. Reloading the tab doesn't help.

Sometimes the popup appears but then immediately disappears. Sometimes it appears but there's a spinner inside that keeps spinning indefinitely. It's weird.

@neongreen
Copy link
Author

Note: I restarted the browser and now the popup always appears but keeps spinning. If I click on "Go to definition", another spinner appears.

@chrismwendt chrismwendt self-assigned this Sep 19, 2018
@chrismwendt chrismwendt added the team/graph Graph Team (previously Code Intel/Language Tools/Language Platform) label Sep 19, 2018
@chrismwendt
Copy link
Contributor

@neongreen Thanks for reporting! This repository is taking a while to compile (not surprising since it depends on lens 😄), and it's exceeding the current timeout of 3 minutes.

I'm working on fixing this by resetting the deadline to 3 minutes from now each time a line is emitted to stderr or a log message is sent. haskell-ide-engine logs messages to stderr during compilation, so this should fix the issue.

I'm also going to look into leaving the repository on disk instead of wiping it for each connection in lsp-adapter. That should leave the .stack-work directory around and speed up the initialization time for subsequent visits to the page.

@chrismwendt
Copy link
Contributor

I bumped the timeout, but now it's OOMing because the machine running the Haskell language server is rather underpowered for this workload. We have plans to improve the infrastructure behind code intelligence for Haskell (and other languages) for a while. I'll post back here with any updates.

@sourcegraph sourcegraph deleted a comment from sourcegraph-bot Oct 9, 2018
@sqs sqs added this to the Backlog milestone Oct 25, 2018
@sqs sqs added the bug An error, flaw or fault that produces an incorrect or unexpected result, or behavior. label Oct 25, 2018
@sqs
Copy link
Member

sqs commented Oct 25, 2018

We are unlikely to be able to fix this before December 2018 at the earliest (see roadmap https://docs.sourcegraph.com/dev/roadmap#december-2018). We will, however, be shipping significant improvements to how lang support is built on Sourcegraph, so someone (you?) could contribute better Haskell support in sooner.

@sqs
Copy link
Member

sqs commented Jan 30, 2019

We removed the Haskell experimental lang server that caused this (see https://about.sourcegraph.com/blog/java-php-experimental_language_servers-temporarily-unavailable).

The preferred way to get Haskell code intelligence is (for now) to use the basic-code-intel extension; see https://about.sourcegraph.com/blog/sourcegraph-3.0-beta-is-now-available#basic-code-intelligence-for-all-languages for info. (On Feb 4, 5 days from when I'm currently writing this, Sourcegraph 3.0 will be released, at which point you can click through on that blog post to the code intelligence section for the 3.0 release.)

@sqs sqs closed this as completed Jan 30, 2019
BolajiOlajide pushed a commit that referenced this issue Apr 16, 2024
* Fix new git based diff generation file paths

* Update cmd/src/actions_exec_backend_runner.go

Co-authored-by: Thorsten Ball <mrnugget@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An error, flaw or fault that produces an incorrect or unexpected result, or behavior. team/graph Graph Team (previously Code Intel/Language Tools/Language Platform)
Projects
None yet
Development

No branches or pull requests

5 participants