Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a GraphQL wrapper API for extensions #15566

Merged
merged 10 commits into from Nov 17, 2020
Merged

Create a GraphQL wrapper API for extensions #15566

merged 10 commits into from Nov 17, 2020

Conversation

tjkandala
Copy link
Contributor

@tjkandala tjkandala commented Nov 9, 2020

Closes #15069.

@tjkandala tjkandala requested review from a team, marekweb and felixfbecker and removed request for a team November 9, 2020 08:08
@codecov
Copy link

codecov bot commented Nov 9, 2020

Codecov Report

Merging #15566 (c96bc1b) into main (565f3ae) will decrease coverage by 0.00%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##             main   #15566      +/-   ##
==========================================
- Coverage   52.36%   52.36%   -0.01%     
==========================================
  Files        1604     1604              
  Lines       80224    80227       +3     
  Branches     7141     7071      -70     
==========================================
  Hits        42013    42013              
- Misses      34530    34534       +4     
+ Partials     3681     3680       -1     
Flag Coverage Δ
go 52.48% <ø> (+<0.01%) ⬆️
integration 28.61% <0.00%> (-0.03%) ⬇️
storybook 26.24% <0.00%> (-0.01%) ⬇️
typescript 52.08% <66.66%> (-0.02%) ⬇️
unit 34.47% <66.66%> (+<0.01%) ⬆️
Impacted Files Coverage Δ
client/shared/src/api/client/connection.ts 84.61% <ø> (ø)
client/shared/src/api/extension/extensionHost.ts 76.47% <ø> (ø)
...lient/shared/src/api/extension/flatExtensionApi.ts 97.70% <50.00%> (-1.13%) ⬇️
client/shared/src/api/client/mainthread-api.ts 100.00% <100.00%> (ø)
...ient/web/src/search/input/LazyMonacoQueryInput.tsx 77.77% <0.00%> (-22.23%) ⬇️
...lient/web/src/search/results/SearchResultsList.tsx 73.12% <0.00%> (-1.25%) ⬇️
.../internal/codeintel/resolvers/graphql/locations.go 81.44% <0.00%> (+2.06%) ⬆️

Copy link
Contributor

@felixfbecker felixfbecker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Copy link
Contributor

@felixfbecker felixfbecker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got a couple more thoughts but otherwise looks fine!

client/shared/src/api/contract.ts Outdated Show resolved Hide resolved
client/shared/src/api/extension/flatExtensionApi.ts Outdated Show resolved Hide resolved
client/shared/src/api/client/mainthread-api.ts Outdated Show resolved Hide resolved
tjkandala and others added 5 commits November 16, 2020 18:47
Co-authored-by: Felix Becker <felix.b@outlook.com>
Co-authored-by: Felix Becker <felix.b@outlook.com>
Co-authored-by: Felix Becker <felix.b@outlook.com>
@tjkandala tjkandala merged commit d11ad25 into main Nov 17, 2020
@tjkandala tjkandala deleted the ext-gql-api branch November 17, 2020 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sourcegraph GraphQL API is undiscoverable in the extension API
2 participants