repo-updater: Small cleanup #17302
Merged
repo-updater: Small cleanup #17302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix a typo and reduce nesting.
74 tasks
Codecov Report
@@ Coverage Diff @@
## main #17302 +/- ##
==========================================
- Coverage 52.14% 52.14% -0.01%
==========================================
Files 1712 1712
Lines 85441 85442 +1
Branches 7596 7596
==========================================
- Hits 44554 44552 -2
- Misses 36972 36975 +3
Partials 3915 3915
*This pull request uses carry forward flags. Click here to find out more.
|
asdine
approved these changes
Jan 15, 2021
1 task
tsenart
reviewed
Jan 15, 2021
| @@ -472,36 +472,39 @@ func (s *Server) repoLookup(ctx context.Context, args protocol.RepoLookupArgs) ( | |||
| return s.remoteRepoSync(ctx, codehost, string(args.Repo)) | |||
| } | |||
|
|
|||
| // We don't sync private repos on demand | |||
| if repo.Private { | |||
| return | |||
There was a problem hiding this comment.
This changes the behaviour though, doesn't it? Before we were not syncing the repo, but we'd return a valid result in https://github.com/sourcegraph/sourcegraph/pull/17302/files#diff-736069860c34f463e5653fc6e82948c934a6771434326e0b79d0e11f63c20f72L513-L520
There was a problem hiding this comment.
Yes, you're right, good catch. I'll revert
ryanslade
added a commit
that referenced
this pull request
Jan 15, 2021
This reverts commit 1630315.
ryanslade
added a commit
that referenced
this pull request
Jan 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a typo and reduce nesting.