sentry: allow specify a DSN for backend #17363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
74 tasks
ryanslade
approved these changes
Jan 18, 2021
| @@ -60,12 +60,21 @@ func Init() { | |||
| return | |||
| } | |||
|
|
|||
| if conf.Get().Log.Sentry == nil { | |||
| sentryConfig := conf.Get().Log.Sentry | |||
There was a problem hiding this comment.
Technically, it's a pointer so it can; practically, unlikely (not sure though).
There was a problem hiding this comment.
Oh I misunderstood your comment.
5 lines above, we checked Log:
if conf.Get().Log == nil {|
|
||
| // Fallback to default DSN if the backend DSN is not specified separately | ||
| if backendDSN == "" { | ||
| backendDSN = sentryConfig.Dsn |
There was a problem hiding this comment.
nit: BackendDSN and Dsn have different cases fordsn
There was a problem hiding this comment.
Ugh... you're right, but Dsn is code-generated (which I hope one day it could generate DSN, HTTP etc.). For native Go names, I prefer DSN over Dsn.
Codecov Report
@@ Coverage Diff @@
## main #17363 +/- ##
==========================================
- Coverage 51.88% 51.88% -0.01%
==========================================
Files 1713 1713
Lines 84963 84963
Branches 7588 7748 +160
==========================================
- Hits 44083 44080 -3
- Misses 36976 36977 +1
- Partials 3904 3906 +2
|
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new site config option
"log": { "sentry": { "backendDSN": "<REDACTED>" } }to set a separate Sentry DSN only for backend errors.Part of #16109