Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert the QueryRunnerState store into a basestore #17410

Merged
merged 1 commit into from
Jan 19, 2021

Conversation

asdine
Copy link
Contributor

@asdine asdine commented Jan 19, 2021

Fixes #15847

@asdine asdine added this to the Cloud 2021-01-13 milestone Jan 19, 2021
@asdine asdine requested a review from a team January 19, 2021 12:27
@codecov
Copy link

codecov bot commented Jan 19, 2021

Codecov Report

Merging #17410 (b72479b) into main (7d19c08) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main   #17410      +/-   ##
==========================================
- Coverage   51.81%   51.80%   -0.01%     
==========================================
  Files        1716     1716              
  Lines       85065    85076      +11     
  Branches     7686     7686              
==========================================
  Hits        44076    44076              
- Misses      37082    37093      +11     
  Partials     3907     3907              
Flag Coverage Δ *Carryforward flag
go 50.84% <0.00%> (-0.01%) ⬇️
integration 30.71% <ø> (ø) Carriedforward from 7d19c08
storybook 29.93% <ø> (ø) Carriedforward from 7d19c08
typescript 54.13% <ø> (ø) Carriedforward from 7d19c08
unit 34.74% <ø> (ø) Carriedforward from 7d19c08

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
internal/db/saved_queries.go 0.00% <0.00%> (ø)

@asdine asdine merged commit 3e4f004 into main Jan 19, 2021
@asdine asdine deleted the asdine/queryRunnerState-store branch January 19, 2021 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Convert the queryRunnerState store to use the basestore package
2 participants