Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

db: Return tx.Done error #17415

Merged
merged 1 commit into from
Jan 19, 2021
Merged

db: Return tx.Done error #17415

merged 1 commit into from
Jan 19, 2021

Conversation

ryanslade
Copy link
Contributor

The previous code would ignore the error returned by tx.Done

@ryanslade
db: Return tx.Done error
b66142a 
The previous code would ignore the error returned by tx.Done
@ryanslade ryanslade added this to the Cloud 2021-01-13 milestone Jan 19, 2021
@ryanslade ryanslade requested a review from asdine January 19, 2021 13:03
@ryanslade
Copy link
Contributor Author

@asdine I noticed this is how you were handling the tx.Done errors in the other basestore conversions.

asdine
asdine approved these changes Jan 19, 2021
View reviewed changes
Copy link
Contributor

@asdine asdine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Yeah this is how it should be handled apparently, this is what I've seen in other parts of the code

@ryanslade ryanslade merged commit 97793ca into main Jan 19, 2021
@ryanslade ryanslade deleted the user-store-txdone branch January 19, 2021 13:14
@sourcegraph-bot sourcegraph-bot mentioned this pull request Feb 9, 2021
Closed
74 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asdine asdine asdine approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Cloud 2021-01-13
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ryanslade @asdine