Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete the secrets store #17458

Merged
merged 2 commits into from
Jan 20, 2021
Merged

Delete the secrets store #17458

merged 2 commits into from
Jan 20, 2021

Conversation

asdine
Copy link
Contributor

@asdine asdine commented Jan 20, 2021

Fixes #15862

This store is no longer used though, should we remove it? cc @unknwon @chayim

@asdine asdine added this to the Cloud 2021-01-13 milestone Jan 20, 2021
@codecov
Copy link

codecov bot commented Jan 20, 2021

Codecov Report

Merging #17458 (c610ab7) into main (0197ed6) will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main   #17458      +/-   ##
==========================================
- Coverage   51.92%   51.89%   -0.04%     
==========================================
  Files        1716     1715       -1     
  Lines       85218    85076     -142     
  Branches     7749     7749              
==========================================
- Hits        44250    44148     -102     
+ Misses      37066    37046      -20     
+ Partials     3902     3882      -20     
Flag Coverage Δ *Carryforward flag
go 50.88% <ø> (-0.05%) ⬇️
integration 30.64% <ø> (ø) Carriedforward from 94cf5e2
storybook 30.34% <ø> (ø) Carriedforward from 94cf5e2
typescript 54.32% <ø> (ø) Carriedforward from 94cf5e2
unit 34.72% <ø> (ø) Carriedforward from 94cf5e2

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
.../internal/codeintel/resolvers/graphql/locations.go 85.56% <0.00%> (+4.12%) ⬆️

@asdine asdine requested a review from a team January 20, 2021 12:23
@tsenart
Copy link
Contributor

tsenart commented Jan 20, 2021

Yeah, if this isn't used let's nuke it.

@asdine asdine changed the title Convert the Secrects store into a basestore Delete the secrets store Jan 20, 2021
Copy link
Contributor

@chayim chayim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes - since we don't use it, let's.

@asdine asdine merged commit 82bf6cf into main Jan 20, 2021
@asdine asdine deleted the asdine/secrets-store branch January 20, 2021 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Convert the secrets store to use the basestore package
3 participants