db: rename store constructors

[asdine]

Rename store constructors to something shorter, similar to the name of the global store variables. Ex:

// Before:
// access to the global Users store
idb.Users.Create(...)
// creating a UserStore
idx.NewUserStoreWithDB(db)
idx.NewUserStoreWith(otherStore)

// After:
// access to the global Users store
idb.GlobalUsers.Create(...) // (PR #17503)
// creating a UserStore
idx.Users(db).Create(...)
idx.UsersWith(otherStore).Create(...)

[sourcegraph-bot]

Notifying subscribers in CODENOTIFY files for diff 9cbee8c...3dbb13b.

Notify	File(s)
@LawnGnome	enterprise/internal/campaigns/background.go enterprise/internal/campaigns/frontend.go enterprise/internal/campaigns/reconciler/executor.go enterprise/internal/campaigns/resolvers/campaign_connection_test.go enterprise/internal/campaigns/resolvers/campaign_spec_test.go enterprise/internal/campaigns/resolvers/changeset_apply_preview_connection_test.go enterprise/internal/campaigns/resolvers/changeset_apply_preview_test.go enterprise/internal/campaigns/resolvers/changeset_connection_test.go enterprise/internal/campaigns/resolvers/changeset_counts_test.go enterprise/internal/campaigns/resolvers/changeset_event_connection_test.go enterprise/internal/campaigns/resolvers/changeset_spec_connection_test.go enterprise/internal/campaigns/resolvers/changeset_spec_test.go enterprise/internal/campaigns/resolvers/changeset_test.go enterprise/internal/campaigns/resolvers/permissions_test.go enterprise/internal/campaigns/resolvers/resolver_test.go enterprise/internal/campaigns/service/service.go enterprise/internal/campaigns/store/changeset_specs_test.go enterprise/internal/campaigns/store/changesets_test.go enterprise/internal/campaigns/store/codehost_test.go enterprise/internal/campaigns/testing/repos.go enterprise/internal/campaigns/webhooks/webhooks.go enterprise/internal/campaigns/webhooks/webhooks_gitlab_test.go enterprise/internal/campaigns/webhooks/webhooks_test.go internal/db/external_accounts.go internal/db/external_services.go internal/db/namespaces.go internal/db/repos.go
@eseliger	enterprise/internal/campaigns/background.go enterprise/internal/campaigns/frontend.go enterprise/internal/campaigns/reconciler/executor.go enterprise/internal/campaigns/resolvers/campaign_connection_test.go enterprise/internal/campaigns/resolvers/campaign_spec_test.go enterprise/internal/campaigns/resolvers/changeset_apply_preview_connection_test.go enterprise/internal/campaigns/resolvers/changeset_apply_preview_test.go enterprise/internal/campaigns/resolvers/changeset_connection_test.go enterprise/internal/campaigns/resolvers/changeset_counts_test.go enterprise/internal/campaigns/resolvers/changeset_event_connection_test.go enterprise/internal/campaigns/resolvers/changeset_spec_connection_test.go enterprise/internal/campaigns/resolvers/changeset_spec_test.go enterprise/internal/campaigns/resolvers/changeset_test.go enterprise/internal/campaigns/resolvers/permissions_test.go enterprise/internal/campaigns/resolvers/resolver_test.go enterprise/internal/campaigns/service/service.go enterprise/internal/campaigns/store/changeset_specs_test.go enterprise/internal/campaigns/store/changesets_test.go enterprise/internal/campaigns/store/codehost_test.go enterprise/internal/campaigns/testing/repos.go enterprise/internal/campaigns/webhooks/webhooks.go enterprise/internal/campaigns/webhooks/webhooks_gitlab_test.go enterprise/internal/campaigns/webhooks/webhooks_test.go internal/db/external_accounts.go internal/db/external_services.go internal/db/namespaces.go internal/db/repos.go internal/usagestats/campaigns_test.go
@keegancsmith	cmd/gitserver/main.go
@unknwon	enterprise/cmd/frontend/internal/licensing/enforcement/users.go

[codecov]

Codecov Report

Merging #17506 (3dbb13b) into main (9cbee8c) will increase coverage by 5.74%.
The diff coverage is 88.88%.

@@            Coverage Diff             @@
##             main   #17506      +/-   ##
==========================================
+ Coverage   45.97%   51.71%   +5.74%     
==========================================
  Files        1717     1717              
  Lines       85352    85349       -3     
  Branches     7608     7663      +55     
==========================================
+ Hits        39237    44135    +4898     
+ Misses      42229    37326    -4903     
- Partials     3886     3888       +2     

Flag	Coverage Δ		*Carryforward flag
go	50.65% <88.88%> (+<0.01%)	⬆️
integration	30.68% <ø> (?)		Carriedforward from 93a5404
storybook	30.33% <ø> (?)		Carriedforward from 93a5404
typescript	54.26% <ø> (+19.59%)	⬆️	Carriedforward from 93a5404
unit	34.67% <ø> (+<0.01%)	⬆️	Carriedforward from 93a5404

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files	Coverage Δ
cmd/gitserver/main.go	10.12% <0.00%> (ø)
internal/db/access_tokens.go	65.41% <ø> (ø)
internal/db/default_repos.go	50.00% <ø> (ø)
internal/db/event_logs.go	53.52% <ø> (ø)
internal/db/external_accounts.go	64.21% <ø> (ø)
internal/db/external_services.go	66.98% <ø> (ø)
internal/db/namespaces.go	79.06% <ø> (ø)
internal/db/org_invitations.go	59.81% <ø> (ø)
internal/db/org_members.go	55.55% <ø> (ø)
internal/db/orgs.go	48.48% <ø> (ø)
... and 370 more