search: Make new structural search code path default

[camdencheek]

This switches over to using the new structural code search path by
default, so now searcher will query zoekt for the file contents directly
rather than copying over a full repository archive from gitserver.

[sourcegraph-bot]

Notifying subscribers in CODENOTIFY files for diff d9c6225...16ad0d9.

Notify	File(s)
@beyang	cmd/searcher/protocol/searcher.go cmd/searcher/search/search.go cmd/searcher/search/search_test.go
@keegancsmith	cmd/frontend/graphqlbackend/textsearch.go cmd/frontend/graphqlbackend/zoekt.go cmd/searcher/protocol/searcher.go cmd/searcher/search/search.go cmd/searcher/search/search_test.go
@rvantonder	cmd/frontend/graphqlbackend/textsearch.go cmd/frontend/graphqlbackend/zoekt.go

[rvantonder]

Nit: if this PR touches all the parts where we compare to where "zoekt" == "zoekt" (I think it does) then we could rename it to where "backcompat" == "backcompat"

[rvantonder]

Oh I also want this to run on master-dry-run. Unfortunately, the build is currently broken so we can't get a clear signal :(

[camdencheek]

For master-dry-run, I don't have to do anything other than have the branch name prefixed, right?

[rvantonder]

yeah it's also possible to just git checkout -b mastery-dry-run/whatever on this branch and push it up to buildkite, it buildkite usually figures out it's the same commit, but also runs the integration tests

[rvantonder]

But again integration tests are failing right now due to other search changes. I'm wondering if we should hold off on this PR until those are fixed or reverted, and rebase on top...

[camdencheek]

This branch is already named like that though, right? Do I need to do anything?

[rvantonder]

missed that :P

[codecov]

Codecov Report

Merging #17846 (16ad0d9) into main (d9c6225) will decrease coverage by 0.06%.
The diff coverage is 33.33%.

@@            Coverage Diff             @@
##             main   #17846      +/-   ##
==========================================
- Coverage   51.18%   51.11%   -0.07%     
==========================================
  Files        1725     1725              
  Lines       86383    86383              
  Branches     7675     7854     +179     
==========================================
- Hits        44215    44158      -57     
- Misses      38284    38357      +73     
+ Partials     3884     3868      -16     

Flag	Coverage Δ
go	49.84% <33.33%> (-0.11%)	⬇️
integration	30.68% <ø> (-0.02%)	⬇️
storybook	30.41% <ø> (+0.04%)	⬆️
typescript	54.23% <ø> (+0.02%)	⬆️
unit	34.48% <ø> (ø)

Impacted Files	Coverage Δ
cmd/frontend/graphqlbackend/zoekt.go	77.30% <0.00%> (-0.53%)	⬇️
cmd/searcher/search/search.go	65.80% <0.00%> (ø)
cmd/frontend/graphqlbackend/textsearch.go	56.11% <100.00%> (-4.48%)	⬇️
cmd/frontend/graphqlbackend/search_structural.go	4.04% <0.00%> (-52.53%)	⬇️
.../internal/codeintel/resolvers/graphql/locations.go	85.56% <0.00%> (+6.18%)	⬆️
client/shared/src/search/query/providers.ts	62.06% <0.00%> (+20.68%)	⬆️