Extend schema to allow conditional execution of steps #20399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrnugget
force-pushed
the
mrn/schema-conditional-execution
branch
2 times, most recently
from
4bd1326
to
8eda415
Compare
mrnugget
force-pushed
the
mrn/schema-conditional-execution
branch
from
adddb23
to
ad3b106
Compare
eseliger
approved these changes
May 4, 2021
LawnGnome
approved these changes
May 4, 2021
eseliger
approved these changes
May 5, 2021
mrnugget
force-pushed
the
mrn/schema-conditional-execution
branch
from
057cec0
to
9c3cc9a
Compare
mrnugget
added a commit
to sourcegraph/src-cli
that referenced
this pull request
May 6, 2021
This extends the schema of the batch spec `steps` to add a new field: - `if: <string that can use templating to evaluate to "true" or "false">` (the corresponding schema changes `sourcegraph/sourcegraph` are here: sourcegraph/sourcegraph#20399) `if:` is evaluated in a best-effort partial-evaluation manner before the execution of the `steps`. If we can statically evaluate it, we use the result of that evaluation to build a per-repository/per-workspace list of tasks, which increases cache utilisation. See the comments in `partial_eval.go` for more details. It also extends the `StepContext` in the templates to have the `steps.{added,modified,deleted}_files` and `steps.path` fields.
scjohns
pushed a commit
to sourcegraph/src-cli
that referenced
this pull request
Apr 24, 2023
This extends the schema of the batch spec `steps` to add a new field: - `if: <string that can use templating to evaluate to "true" or "false">` (the corresponding schema changes `sourcegraph/sourcegraph` are here: sourcegraph/sourcegraph#20399) `if:` is evaluated in a best-effort partial-evaluation manner before the execution of the `steps`. If we can statically evaluate it, we use the result of that evaluation to build a per-repository/per-workspace list of tasks, which increases cache utilisation. See the comments in `partial_eval.go` for more details. It also extends the `StepContext` in the templates to have the `steps.{added,modified,deleted}_files` and `steps.path` fields.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required schema changes for sourcegraph/src-cli#520