Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

web: more precise typography letter-spacing #20692

Merged
merged 2 commits into from May 6, 2021

Conversation

valerybugakov
Copy link
Member

Description

CSS rules from Figma Inspect for letter-spacing are imprecise for some reason.
This PR changes letter-spacing rules for typography redesign based on Pixel Perfect matching.
Below are the resulting screenshots: text with opacity — screenshots from Figma at 100% zoom.

Headings

headings

Label / Base

label-base

Label / Small

label-small

Label / Uppercase

label-uppercase

@valerybugakov valerybugakov added frontend-platform Issues related to our frontend platform, owned collectively by our frontend crew. design refresh Issues connected to the design refresh of 2021 labels May 6, 2021
@valerybugakov valerybugakov requested review from rrhyne and a team May 6, 2021 04:24
@valerybugakov valerybugakov self-assigned this May 6, 2021
@valerybugakov valerybugakov marked this pull request as ready for review May 6, 2021 08:28
@valerybugakov valerybugakov enabled auto-merge (squash) May 6, 2021 08:38
@valerybugakov valerybugakov merged commit a9df79d into main May 6, 2021
@valerybugakov valerybugakov deleted the vb/typography-letter-spacing branch May 6, 2021 08:39
@sourcegraph-bot sourcegraph-bot mentioned this pull request Jun 7, 2021
28 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design refresh Issues connected to the design refresh of 2021 frontend-platform Issues related to our frontend platform, owned collectively by our frontend crew.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants