Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

web: fix close button position in dismissible alert #21724

Merged
merged 3 commits into from Jun 4, 2021
Merged

web: fix close button position in dismissible alert #21724

merged 3 commits into from Jun 4, 2021

Conversation

valerybugakov
Copy link
Member

@valerybugakov valerybugakov commented Jun 4, 2021 •
edited

Description

Fixed the alignment of the close button for the one-line dismissible alert. Closes #21693.

Changes

  • Converted DimissibleAlert styles into a CSS module.
  • Fixed close button position for the one-line DismissibleAlert.
  • Added DismissibleAlert.story.tsx.
  • Removed redundant alert class name passed to DismissibleAlert as a prop.

Screenshots

One-line alert:

Screenshot 2021-06-04 at 09 59 48

Multiline alert:

Screenshot 2021-06-04 at 09 59 56

@valerybugakov valerybugakov added frontend-platform Issues related to our frontend platform, owned collectively by our frontend crew. design refresh Issues connected to the design refresh of 2021 labels Jun 4, 2021
@valerybugakov valerybugakov self-assigned this Jun 4, 2021
@valerybugakov valerybugakov requested review from rrhyne, eseliger and a team June 4, 2021 07:33
@valerybugakov valerybugakov marked this pull request as ready for review June 4, 2021 07:33
@sourcegraph-bot
Copy link
Contributor

Notifying subscribers in CODENOTIFY files for diff 51785f2...8b34d80.

Notify File(s)
@eseliger client/web/src/enterprise/batches/detail/BulkOperationsAlerts.tsx
client/web/src/enterprise/batches/detail/ChangesetsArchivedNotice.tsx
client/web/src/enterprise/batches/detail/SupersedingBatchSpecAlert.tsx

@valerybugakov valerybugakov merged commit 45d3bff into main Jun 4, 2021
@valerybugakov valerybugakov deleted the vb/dismissible-alert-story branch June 4, 2021 13:39
eseliger
eseliger reviewed Jun 4, 2021
View reviewed changes
Copy link
Member

@eseliger eseliger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@sourcegraph-bot sourcegraph-bot mentioned this pull request Jun 7, 2021
Closed
28 tasks
@sourcegraph-bot sourcegraph-bot mentioned this pull request Jun 17, 2021
Closed
14 tasks
@realize096 realize096 mentioned this pull request Nov 27, 2023
Open
@baldwin323 baldwin323 mentioned this pull request Nov 28, 2023
Open
@baldwin323 baldwin323 mentioned this pull request Jan 9, 2024
Open
@Liselot3 Liselot3 mentioned this pull request Jan 9, 2024
Merged
@dixiemom1328 dixiemom1328 mentioned this pull request Jan 9, 2024
Open
@realize096 realize096 mentioned this pull request Jan 9, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eseliger eseliger eseliger left review comments

@umpox umpox umpox approved these changes

@rrhyne rrhyne Awaiting requested review from rrhyne

Assignees

@valerybugakov valerybugakov

Labels
design refresh Issues connected to the design refresh of 2021 frontend-platform Issues related to our frontend platform, owned collectively by our frontend crew.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DismissibleAlert close icon is off center for one-line alerts
4 participants
@valerybugakov @sourcegraph-bot @umpox @eseliger